patron stat cat information persists from patron to patron

Bug #1844365 reported by Chris Sharp
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.5
Fix Released
High
Unassigned

Bug Description

Found in PINES 3.2.X production. If you enter the "Edit" screen within a patron account, then click "Patron Search" in the upper right and retrieve another patron, the Patron Stat Cat values that were present in the previous account are filled in on the new patron's screen. If you save the new patron without changing those values, they will be saved in the new patron's account. Steps to test on current master:

1) create a patron stat cat in Administration -> Local Administration -> Statistical Categories editor and assign multiple entries (at least two) for CONS or the branch unit where you're logged in.

2) open an existing patron account and assign a stat cat value (Patron Stat Cat).

3) retrieve a new patron using the Patron Search button in the upper right.

4) confirm that the previous patron's values are entered in the Patron Stat Cat field.

We've learned that refreshing the screen in the browser controls removes the value, but unless you know that or are paying careful attention, it will enter undesired data upon saving.

Evergreen 3.2+
OpenSRF 3.1
PostgreSQL 9.5
Ubuntu 16.04 LTS

Revision history for this message
Terran McCanna (tmccanna) wrote :

This is still a problem in 3.4.2. The patron stat cat field is so sticky that it carries over from one patron edit screen to the next patron edit screen.

Changed in evergreen:
importance: Undecided → High
tags: added: usability
Revision history for this message
Mike Risher (mrisher) wrote :

There is work completed that ports this UI from Angular JS over to Angular. Here's the launchpad page: https://bugs.launchpad.net/evergreen/+bug/1857911

I'm trying to check if this solves the issue, but I'm having troubles replicating the problem on my end in either the old or new interface. More detail on replicating would be helpful, or perhaps a short video clip showing how to replicate step by step.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Hi Mike - the bug isn't in the Stat Cat interface, it's in the Patron Edit interface. Video here:

https://screencast-o-matic.com/watch/cYnYoqwEeM

Revision history for this message
Mike Risher (mrisher) wrote :

Thank you for the video. It made it easy to replicate the problem. I put a fix in place so that when you navigate to the search page it erases the stored stat cat for the previous patron. Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=4f228a0d205e676a27d33a97bc5f8238667af55c

Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a counter-proposal here:

user/gmcharlt/lp1844365_counter_proposal / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1844365_counter_proposal

This has the same effect as Mike's patch, but avoids having the main patron app dig into the internals of patronRegSvc.

tags: added: needsdiscussion
Revision history for this message
Mike Risher (mrisher) wrote :

I tested Galen's patch and it works as advertised. I think it's a cleaner approach and preferable to what I submitted. I consent to sign off on it with my name, Mike Risher <email address hidden>

Galen Charlton (gmc)
tags: removed: needsdiscussion
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed all the way to rel_3_3. Thanks for testing my counter-patch, Mike!

Changed in evergreen:
status: Confirmed → Fix Committed
no longer affects: evergreen/3.3
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.