[eoan] Thunderbird 68.0 does not include attachment coming from an external app

[Francois Thirioux]

(Eoan up-to-date, GNOME session)

When I choose to "send to" my PDF or image from Eog or Evince (probably others too), TB 68 new message window appears but no file is attached. Same issue inside Nautilus (right-click on a file, send to).

Was fully ok with TB 60.* .

[Klaus-riech (klaus-riech)]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I sent a windows shell command (to be precise using the VBA command "shell"):
C:\Program Files (x86)\Mozilla Thunderbird\Thunderbird.exe -compose "<email address hidden>',cc='',subject='mysubject',body='Dear Mr Test',attachment='C:\test.txt' "

Actual results:

Thunderbird opens. A new Mail is created.
The Mail is completely empty, no TO, not SUBJECT, no BODY - and nothing attached.

If I remove the command line argument "attachment". The Mail opens perfectly normal with TO, SUBJECT and BODY.

Expected results:

The Mail should have been created with TO ("<email address hidden>"), SUBJECT ("mysubject"), BODY ("Dear Mr Test") and the file "test.txt" attached to it.

[Vseerror (vseerror)]

Thanks for filing the bug

[Mkmelin+mozilla (mkmelin+mozilla)]

Hmm. Apparently because Cc["@mozilla.org/toolkit/command-line;1"] is gone.

[Jorg K (jorgk)]

Sigh, we use:
`let commandLine = Cc["@mozilla.org/toolkit/command-line;1"]`
https://searchfox.org/comm-central/rev/753e6d9df9d7b9a989d735b01c8b280eef388bab/mail/components/compose/content/MsgComposeCommands.js#2676

And that XPCOM API has disappeared from M-C in bug 1491560: https://hg.mozilla.org/mozilla-central/rev/7a4dadc9c3e6

So we need to restore this.

[Jorg K (jorgk)]

This will do it: Cu.createCommandLine().
EDIT: From https://hg.mozilla.org/mozilla-central/rev/7a4dadc9c3e6#l3.12

[Jorg K (jorgk)]

Created attachment 9088694
1577117-command-line.patch

Works fine locally, I used:
thunderbird.exe -compose "<email address hidden>,subject=mysubject,body='Dear Mr Test',attachment=D:\Desktop\BVG-Preise-2016.pdf "

[Jorg K (jorgk)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/6abdadcb296d084759a5596380010bacdf0027d7

[Pulsebot (pulsebot)]

Pushed by <email address hidden>:
https://hg.mozilla.org/comm-central/rev/bcc11bb0ae6c
create command line via Cu.createCommandLine() after bug 1491560. r=me

[Mkmelin+mozilla (mkmelin+mozilla)]

Comment on attachment 9088694
1577117-command-line.patch

Review of attachment 9088694:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

[Mkmelin+mozilla (mkmelin+mozilla)]

Related to this, I think it was unnoticed because at https://searchfox.org/comm-central/rev/753e6d9df9d7b9a989d735b01c8b280eef388bab/mail/components/compose/content/MsgComposeCommands.js#3047 we don't really get a prompt, only the "Cannot call openModalWindow on a hidden window" error.

[Jorg K (jorgk)]

Hmm, well, no one uses -compose " ... attachment= ..." on Daily or Beta. I tried in on 68.1, works fine again.
EDIT: I see, you mean the debug console doesn't show it. Right.

[Jorg K (jorgk)]

*** Bug 1578180 has been marked as a duplicate of this bug. ***

[Jorg K (jorgk)]

*** Bug 1578657 has been marked as a duplicate of this bug. ***

[Jorg K (jorgk)]

*** Bug 1579370 has been marked as a duplicate of this bug. ***

[Jorg K (jorgk)]

*** Bug 1579533 has been marked as a duplicate of this bug. ***

[Jorg K (jorgk)]

*** Bug 1579741 has been marked as a duplicate of this bug. ***

[Jorg K (jorgk)]

*** Bug 1580119 has been marked as a duplicate of this bug. ***

[Olivier Tilloy (osomon)]

This is fixed in 68.1.0, for which I'll be preparing an update soon (https://www.thunderbird.net/en-US/thunderbird/68.1.0/releasenotes/).

[Launchpad Janitor (janitor)]

This bug was fixed in the package thunderbird - 1:68.1.1+build1-0ubuntu1

---------------
thunderbird (1:68.1.1+build1-0ubuntu1) eoan; urgency=medium

  * New upstream stable release (68.1.1build1)

  * Build thunderbird against the system-wide version of sqlite3 (LP: #1845929)
    - update debian/config/mozconfig.in
    - update debian/control{,.in}

 -- Olivier Tilloy <email address hidden> Tue, 01 Oct 2019 14:47:00 +0200

[Martin Schniewind (7-martix-1)]

Bug seems still/again to be present.

Ubuntu Mate 20.04

Tried Thunderd versions:
- TB 68.10.0 from regular repository
- TB 78.5.1 from PPA ubuntu-mozilla-security/ppa

Tried to launch Composer from LibreOffice Menu ("send as PDF"):
 - composer window shows up, but deserved attechment is missing

Tried to launch Composer from command line with parameters "to", "from", "subject", "attachment":
- composer window shows up
- "to", "from", "subject" beeing set as expected
- no file attached

With Evolution adding attachments works as expected in all cases.