Unable to open edit dialog at all when "edit changes track width" is active

[Ian McInerney]

When the "edit changes track width" is selected in preferences, it also makes it so the properties context menu item changes the track width instead of opening the properties window. This means that there is no way of actually editing a trace's properties when that option is activated.

It seems that the context menu action should not be overridden by the preference, so that action is only modified when using the keyboard. That way you could still open the edit window to change other properties about the trace without having to go into preferences and change the option.

Application: Pcbnew
Version: (5.1.4-75-gf1436cec9), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib nghttp2/1.38.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

This also affects the master branch, but I wonder if that preference is still useful in that branch or if we should create a separate action that updates the track width to the current value. Thoughts?

[Seth Hillbrand (sethh)]

I have a strong preference for just moving this behavior to its own action+hotkey rather than having an override on a different action. Not sure where other devs come down on this question.

[Jeff Young (jeyjey)]

I never liked it either, but then I didn’t have a long history of using older versions, so my hands had no muscle memory.

[Wayne Stambaugh (stambaughw)]

I'm with Seth on this. A different hotkey would be a better solution. At one time the default hotkey to change the track width was 'W' and I believe that it change the width of the entire track not just the current segment.

[Jeff Young (jeyjey)]

Added new action for "Change Track Width". Default out-of-the-box is no hotkey. Removed all the preference stuff.

(Note that the implementation is a little different: the only one only acted on a selection with a single item where the new one operates on all selected items. So if you want the whole track do a 'U' before the 'W' -- or whatever you have Change Track Width assigned to.)

[KiCad Janitor (kicad-janitor)]

Fixed in revision 48c8ac96638569dad4ca77f68f8f0f240c250da7
https://git.launchpad.net/kicad/patch/?id=48c8ac96638569dad4ca77f68f8f0f240c250da7