Inconsistent use of auxiliary files path

[Ryan Beisner]

Some charms need to cargo and ship a script or other file in the charm tree. These are typically not part of actions, hooks, or other libraries. These are also typically not appropriate for Juju resource usage. Across OpenStack Charms, there are varying locations for this type of auxiliary file.

In the name of consistency, and in line with a batch normalization of tox files across OpenStack Charms, I'm proposing to settle on one consistent parent path:

rabbitmq-server has a ./scripts/ dir, let's move that to ./files/.

hacluster has an ./ocf/ dir, let's move that into a new ./files/ dir.

glance-simplestreams-sync has a ./scripts/ dir, let's move that to ./files/.

[Ryan Beisner (1chb1n)]

https://review.opendev.org/#/q/topic:bug/1843826+(status:open+OR+status:merged)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/681916

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/681920

[Ryan Beisner (1chb1n)]

For added context, the ceph-* charms already use the ./files/ dir location.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681913
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=8cc2df51aac4b7abda636ecdd04c4bbe3932db5e
Submitter: Zuul
Branch: master

commit 8cc2df51aac4b7abda636ecdd04c4bbe3932db5e
Author: Ryan Beisner <email address hidden>
Date: Thu Sep 12 15:12:45 2019 -0500

    Standardize auxiliary file location across os-charms

    Change-Id: I644db5de7a5dc1f41d13f2aa13cc1fa5c00c8b83
    Closes-Bug: #1843826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681916
Committed: https://git.openstack.org/cgit/openstack/charm-hacluster/commit/?id=6ed2bb09433fb2da8d0a22185be23e04d8360814
Submitter: Zuul
Branch: master

commit 6ed2bb09433fb2da8d0a22185be23e04d8360814
Author: Ryan Beisner <email address hidden>
Date: Thu Sep 12 15:20:51 2019 -0500

    Standardize auxiliary file location across os-charms

    Change-Id: Ifaa5453bc0703c77184184e05c53d21649f6b92e
    Closes-Bug: #1843826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681920
Committed: https://git.openstack.org/cgit/openstack/charm-glance-simplestreams-sync/commit/?id=e69a562494579d3846054390636a0775421b4436
Submitter: Zuul
Branch: master

commit e69a562494579d3846054390636a0775421b4436
Author: Ryan Beisner <email address hidden>
Date: Thu Sep 12 15:27:36 2019 -0500

    Standardize auxiliary file location across os-charms

    Change-Id: Ic06c4fcdd87d350a0e41cb9de62bd7887aae7168
    Closes-Bug: #1843826