Pcbnew: breaking wire resets interactive Router mode to "highlight collisions"

[Nikolaus Trnka]

Application: Pcbnew
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Start Pcbnew, set interactive Router Mode to push&shove or going round, create a copper wire, leave the routing mode via Esc, right cklick on the wire and use "breaking wire". The interactive Router mode is resetted to "highlight collisions". It happens with both modes push&shove and going round.

[Ian McInerney (imcinerney)]

This occurs in both the 5.1 branch and master. It doesn't jump to the Highlight Collisions mode, but instead defaults to the user's default setting (mine was switching back to the walk around mode).

[Ian McInerney (imcinerney)]

Turns out the settings were being reloaded every time the break action was being run.

(Sorry for the whitespace changes in this patch, my editor automatically removes trailing spaces on save and this file seems to have had quite a few of them).

[Ian McInerney (imcinerney)]

Lets try this again with the fixes line this time...

[Ian McInerney (imcinerney)]

Here is one for 5.1, since the previous patch doesn't apply cleanly due to this whitespace changes (it was built on master).

[Wayne Stambaugh (stambaughw)]

@Ian, I merged your patches into the master and 5.1 branches. Thanks.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 58d4a8bb4a65a258b99077fff48b7b9f4a4eee8d
https://git.launchpad.net/kicad/patch/?id=58d4a8bb4a65a258b99077fff48b7b9f4a4eee8d