emergency save does not work in trunk

[MenTaLguY]

It looks like (versus 0.45?) that emergency save in trunk doesn't work at all. Steps to reproduce:

1. open a document, make some changes
2. kill Inkscape with SIGSEGV or SIGABRT or something similarly fatal
3. the emergency save code is triggered, but no names of emergency-saved files are printed, and no emergency save files appear in the filesystem

[MenTaLguY (mental-deactivatedaccount)]

Given that 0.46 is unlikely to be very stable, this is pretty important to fix before the release.

[MenTaLguY (mental-deactivatedaccount)]

It looks like the issue is that inkscape->documents is not getting populated. This should be being performed by the document views.

[MenTaLguY (mental-deactivatedaccount)]

and, indeed, there are calls to inkscape_add_document and inkscape_remove_document from View::setDocument, as there should be (although multiple views will be slightly broken in this regard -- there really needs to be a "view reference count" kept somewhere so the document is only added when the first view for it is established, and only removed when the last view goes away)

[MenTaLguY (mental-deactivatedaccount)]

Hm, there seems to be some confusion between inkscape->document_set and inkscape->documents in the code. We should get rid of one entirely (i.e. inkscape->documents).

[MenTaLguY (mental-deactivatedaccount)]

Hm, no, actually the code as written should work. The document_set multiset contains duplicates, whereas documents does not. This will require further investigation.

[MenTaLguY (mental-deactivatedaccount)]

(well, right now ->documents does not contain anything at all; it _should_ contain the list of active documents, without duplicates)

[MenTaLguY (mental-deactivatedaccount)]

Fixed in r17234