Flavors in nova - hw_rng:rate_period should be in milliseconds

[Jordan Ansell]

This doc is inaccurate in this way:
"hw_rng:rate_period" is actually in *milliseconds*

See https://libvirt.org/formatdomain.html#elementsRng

-----------------------------------
Release: 16.1.9.dev7 on 2019-08-23 17:35
SHA: 6e2ec5c5a397b508cddb646e865b6f4d2132f1d6
Source: https://git.openstack.org/cgit/openstack/nova/tree/doc/source/admin/flavors.rst
URL: https://docs.openstack.org/nova/pike/admin/flavors.html

[Matt Riedemann (mriedem)]

Note the glance metadata for the image property says the same:

https://github.com/openstack/glance/blob/54329c6a21b0d3f845b09e79f710fc795976a175/etc/metadefs/compute-randomgen.json#L23

[Matt Riedemann (mriedem)]

Looking at the libvirt driver code it does not do any conversion from seconds to milliseconds so yeah the docs are wrong when looking at the libvirt docs. The flavor extra spec docs should also mention that is a libvirt-only spec at the moment, no other compute driver is using that spec.

[Takashi Natsume (natsume-takashi)]

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/689158

[Jordan Ansell (jordancat)]

Hi Takashi,

Thank you so much for handling this change. I'm new to openstack and
working in opensource, so I appreciate that the process has been taken
care of after I encountered this documentation error, and for your work
on this.

Regards :)
Jordan Ansell

On 18/10/19 2:48 AM, Takashi NATSUME wrote:
> *** This bug is a duplicate of bug 1843542 ***
> https://bugs.launchpad.net/bugs/1843542
>
> Fix proposed to branch: stable/pike
> Review: https://review.opendev.org/689158
>
>
> ** This bug has been marked a duplicate of bug 1843542
> Flavor property "hw_rng:rate_period" should be milliseconds
>