Peer assessment sign-off block has incorrect message

Bug #1843206 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Rebecca Blundell

Bug Description

test/behat/features/user_content/peer_assessment.feature is failing quite a bit on ln 66: And I follow "Return to pages and collections"

Adding a 1 second wait seems to help with this.

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10316

Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Robert Lyon (robertl-9) wrote : Re: Behat: peer_assessment.feature not seeing Return to p+c button

Hi Rebecca,

I'm going to usurp this bug into fixing a bigger issue relating to this feature file.

Namely the message in the feature - "This block's content is displayed below the page heading rather than in a block itself on the page." - is actually now incorrect as the signoff block does not do that any more.

And I'll update your patch to reflect this new issue

Cheers

Robert

summary: - Behat: peer_assessment.feature not seeing Return to p+c button
+ Peer assessment sign-off block has incorrect message
Changed in mahara:
milestone: none → 20.04.0
importance: Medium → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10316
Committed: https://git.mahara.org/mahara/mahara/commit/b04c0d7462401c1da656d2f122a1b8eabb2261a3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b04c0d7462401c1da656d2f122a1b8eabb2261a3
Author: Rebecca Blundell <email address hidden>
Date: Mon Sep 9 12:57:28 2019 +1200

Bug 1843206: Adjust the sign-off block text in edit mode

And adding 1 sec wait times to behat test

Change-Id: Ice92fc6caaa828b40ad8d3c09fc5a0451c381de5

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.