Remove dependency on Libvirt packages on the overcloud system and remove it from the overcloud image

[Piotr Kopec]

Description
===========

Nova services are now running in the containers but we have still a lot of libvirt packages installed on Overcloud systems. Right now there are a couple of information used from the host system inside the containers which requires libvirt packages being installed on the host. Examples:

* /etc/libvirt is bind mounted into nova_virtlogd and nova_libvirt container [1]. Shared resources from there are used.
* until we can fully switch to docker tripleo::profile::base::nova::compute::libvirt_guests runs nova::compute::libvirt_guests on the compute which requires libvirt-client to be installed on the host [2]

We can remove it after removing those dependencies.

[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-libvirt-container-puppet.yaml#L683
[2] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/nova/nova-libvirt-guests-container-puppet.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/681092

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/682255

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681092
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=42eb7c98b6d124a4a3c711cf8da217f75a1d1163
Submitter: Zuul
Branch: master

commit 42eb7c98b6d124a4a3c711cf8da217f75a1d1163
Author: Piotr Kopec <email address hidden>
Date: Tue Nov 19 09:45:05 2019 +0100

    Remove libvirt packaged dependencies

    Nova services are now running in the containers but we have still
    a lot of libvirt packages installed on Overcloud systems.
    To delete unnecessary packages on host systems I'm removing following
    dependencies:
    * modifying NovaLibvirtGuests service to run in containers and generate
      config files for libvirt-guests
    * removeing hard dependencies for libvirt-guests service to
      virt-guest-shutdown.target.
      packages.

    Change-Id: I2d0557127f88a492b283897767e57ea126adfe83
    Closes-Bug: 1842932

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/682255
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=359bc74c7602b27a803039557c9c5767e2bf0df6
Submitter: Zuul
Branch: master

commit 359bc74c7602b27a803039557c9c5767e2bf0df6
Author: Piotr Kopec <email address hidden>
Date: Mon Sep 16 00:17:07 2019 +0200

    Remove libvirt package

    Nova services are now running in the containers but we still have
    libvirt packages installed on Overcloud systems. This change removes
    libvirt packages that are not needed any more.

    Depends-On: https://review.opendev.org/681092
    Change-Id: I1220eda28cb8d21098c26aa548305004567e6e03
    Closes-Bug: 1842932

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/702836

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/702837

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702836
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=220661582ef61b7cf81f4ee3c9cd52b050a76ea8
Submitter: Zuul
Branch: stable/train

commit 220661582ef61b7cf81f4ee3c9cd52b050a76ea8
Author: Piotr Kopec <email address hidden>
Date: Tue Nov 19 09:45:05 2019 +0100

    Remove libvirt packaged dependencies

    Nova services are now running in the containers but we have still
    a lot of libvirt packages installed on Overcloud systems.
    To delete unnecessary packages on host systems I'm removing following
    dependencies:
    * modifying NovaLibvirtGuests service to run in containers and generate
      config files for libvirt-guests
    * removeing hard dependencies for libvirt-guests service to
      virt-guest-shutdown.target.
      packages.

    Change-Id: I2d0557127f88a492b283897767e57ea126adfe83
    Closes-Bug: 1842932
    (cherry picked from commit 42eb7c98b6d124a4a3c711cf8da217f75a1d1163)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702837
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=ec988dda106bbf72de6f785ddf17f4ec022cf68b
Submitter: Zuul
Branch: stable/train

commit ec988dda106bbf72de6f785ddf17f4ec022cf68b
Author: Piotr Kopec <email address hidden>
Date: Mon Sep 16 00:17:07 2019 +0200

    Remove libvirt package

    Nova services are now running in the containers but we still have
    libvirt packages installed on Overcloud systems. This change removes
    libvirt packages that are not needed any more.

    Depends-On: https://review.opendev.org/702836
    Change-Id: I1220eda28cb8d21098c26aa548305004567e6e03
    Closes-Bug: 1842932
    (cherry picked from commit 359bc74c7602b27a803039557c9c5767e2bf0df6)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/707621

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707401
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=852dc1013d6c18113049468ceb1c1a6178aeb4cf
Submitter: Zuul
Branch: stable/train

commit 852dc1013d6c18113049468ceb1c1a6178aeb4cf
Author: Piotr Kopec <email address hidden>
Date: Tue Nov 19 09:45:05 2019 +0100

    Remove libvirt packaged dependencies

    This re-apply change reverted in I6db56cec954c4d6272548791e6b73bd01b177769
    Problem has been fixed in master and the fix is squashed in this change

    Nova services are now running in the containers but we have still
    a lot of libvirt packages installed on Overcloud systems.
    To delete unnecessary packages on host systems I'm removing following
    dependencies:
    * modifying NovaLibvirtGuests service to run in containers and generate
      config files for libvirt-guests
    * removeing hard dependencies for libvirt-guests service to
      virt-guest-shutdown.target.
      packages.

    Change-Id: I2d0557127f88a492b283897767e57ea126adfe83
    Closes-Bug: 1842932
    (cherry picked from commit 42eb7c98b6d124a4a3c711cf8da217f75a1d1163)

    Create qemu user/group on controller

    Deployment is failing with error [1] because the owner/group
    of the TLS generated certificate and key were set to 'qemu'.
    This user and group exist on compute nodes, but not on controller.
    [1] Error: Could not find group qemu"

    This patch adds 'qemu' user/group on controller node to
    resolve the issue as this user is required to retrieve the cert,
    used by the VNC proxy, the same way as on the compute nodes.

    Change-Id: I3aa774c06d91a3b67726fad0d0ca409cda5b78b9
    Closes-Bug: #1860971
    (cherry picked from commit b8c6154e7afda5525be00189afde15dac649a7b2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707621
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=7292c78227e892d8e2cd31b89729223d5be674b3
Submitter: Zuul
Branch: stable/train

commit 7292c78227e892d8e2cd31b89729223d5be674b3
Author: Piotr Kopec <email address hidden>
Date: Mon Sep 16 00:17:07 2019 +0200

    Remove libvirt package

    This re-apply the reverted in I9551aa04c81387c672d4c276ac8d58b2f85fb9ad
    Problem has been fixed in master and will be backported as part of
    https://review.opendev.org/#/c/707401

    Nova services are now running in the containers but we still have
    libvirt packages installed on Overcloud systems. This change removes
    libvirt packages that are not needed any more.

    Depends-On: https://review.opendev.org/707401
    Closes-Bug: 1842932
    (cherry picked from commit 359bc74c7602b27a803039557c9c5767e2bf0df6)

    Change-Id: Ib1a3ce4d102999a06a8dc73486597d7aaf03be96

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 11.2.2 release.