kolla-ansible

$net_default_ip in ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2 breaks ironic standalone uefi deployment

Bug #1842078 reported by Jan Horstmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Jan Horstmann
kolla-ansible 9.0.0 "Train"
Train
Fix Released
Medium
Jan Horstmann
kolla-ansible 9.0.0 "Train"

Bug Description

In an ironic standalone deployment using "deploy_boot_mode: uefi" /tftpboot/$net_default_ip is not set. Upstream went from $net_default_ip to $net_default_mac in https://review.opendev.org/#/c/578959/ for this reason.
kolla-ansible should use the same value as default in "ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/679455

Changed in kolla-ansible:
assignee: nobody → Jan Horstmann (janhorstmann)
status: New → In Progress
Jan Horstmann (janhorstmann)
Changed in kolla-ansible:
assignee: Jan Horstmann (janhorstmann) → nobody
status: In Progress → Fix Committed
assignee: nobody → Jan Horstmann (janhorstmann)
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/679455
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=870cb1beb229d6f856da4c974ca7e73d3d89d56d
Submitter: Zuul
Branch: master

commit 870cb1beb229d6f856da4c974ca7e73d3d89d56d
Author: Jan Horstmann <email address hidden>
Date: Fri Aug 30 15:52:01 2019 +0200

    Use net_default_mac in ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Upstream ironic went from $net_default_ip to $net_default_mac in
    ironic/drivers/modules/master_grub_cfg.txt with
    https://review.opendev.org/#/c/578959/

    This commit makes the same change for
    ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Using $net_default_ip breaks ironic standalone deployments with
    [dhcp]dhcp_provider = none

    Change-Id: I2ca9a66d2bdb0aab5cd9936c8be8206e6ade3bd5
    Closes-Bug: 1842078

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
Jan Horstmann (janhorstmann) wrote :

The commit in https://review.opendev.org/#/c/578959/
is found in rocky and stein stable branches so maybe this should be backported in kolla-ansible as well?

git branch --contains b464a195bb066cc78a05bf27752a1773672e73e5
* bug/2006478
  master
  stable/rocky
  stable/stein

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/679638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/679639

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.opendev.org/679639
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d48164e1444b7703710d526a23be64a2e658bd56
Submitter: Zuul
Branch: stable/rocky

commit d48164e1444b7703710d526a23be64a2e658bd56
Author: Jan Horstmann <email address hidden>
Date: Fri Aug 30 15:52:01 2019 +0200

    Use net_default_mac in ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Upstream ironic went from $net_default_ip to $net_default_mac in
    ironic/drivers/modules/master_grub_cfg.txt with
    https://review.opendev.org/#/c/578959/

    This commit makes the same change for
    ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Using $net_default_ip breaks ironic standalone deployments with
    [dhcp]dhcp_provider = none

    Change-Id: I2ca9a66d2bdb0aab5cd9936c8be8206e6ade3bd5
    Closes-Bug: 1842078
    (cherry picked from commit 870cb1beb229d6f856da4c974ca7e73d3d89d56d)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/679638
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1067aed2cb529d264a725f7583f71c384ae09731
Submitter: Zuul
Branch: stable/stein

commit 1067aed2cb529d264a725f7583f71c384ae09731
Author: Jan Horstmann <email address hidden>
Date: Fri Aug 30 15:52:01 2019 +0200

    Use net_default_mac in ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Upstream ironic went from $net_default_ip to $net_default_mac in
    ironic/drivers/modules/master_grub_cfg.txt with
    https://review.opendev.org/#/c/578959/

    This commit makes the same change for
    ansible/roles/ironic/templates/ironic_pxe_uefi.default.j2

    Using $net_default_ip breaks ironic standalone deployments with
    [dhcp]dhcp_provider = none

    Change-Id: I2ca9a66d2bdb0aab5cd9936c8be8206e6ade3bd5
    Closes-Bug: 1842078
    (cherry picked from commit 870cb1beb229d6f856da4c974ca7e73d3d89d56d)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.1.2

This issue was fixed in the openstack/kolla-ansible 7.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.0.1

This issue was fixed in the openstack/kolla-ansible 8.0.1 release.

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.