Eeschema: Allow single-click highlight of symbols

[Evan Shultz]

From https://bugs.launchpad.net/kicad/+bug/1837809

-One cannot single-click to highlight a symbol, though window-selecting a single symbol does cross-probe and zoom in Pcbnew. Regardless of if the symbol outline has background fill or not, Eeschema could know the click was inside the symbol body. It is intuitive to click inside a symbol and expect highlighting.
-It is rather easy to use the window-select on a single symbol and get nothing, seemingly because the window isn't wide enough though that doesn't seem like a reasonable limitation. See the video attached below.

Application: Eeschema
Version: (5.1.0-1584-gc85d1fa00), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Evan Shultz (evan-shultz)]

As you can see, dragging the window left and right affects this because the direction of the drag affects the "any-part" vs "whole element" selection type.

While this is super convenient during most Eeschema work, here it seems not useful. Allowing a single-click on a symbol to highlight the symbol would eliminate this quirk.

[Jeff Young (jeyjey)]

The drag-selection confusion is because this is actually the Selection tool running underneath the Net Highlight tool, rather than the Net Highlight Tool being inconsistent.

The single-click-symbol issue stems from the fact that @Evan wants this tool to be the "Cross Probe" tool, where it's currently the "Net Highlight" tool.

I've fixed the first problem, and am going to close this bug.

I encourage Evan to log a new one for "Turn Net Highlight Tool into Cross Probe Tool", and then we can flag that one as a Wishlist item.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 79d062aefcdeda4305e50a595e69dfca33bbee06
https://git.launchpad.net/kicad/patch/?id=79d062aefcdeda4305e50a595e69dfca33bbee06

[Jeff Young (jeyjey)]

Note: I cherry-picked the Pcbnew part of this (which had the same issue with running the selection tool under a picker tool), but back-porting the Eeschema part back to 5.1's block architecture would be far riskier. (A quick test revealed issues with wires getting started on the mouse-up event.)

[Evan Shultz (evan-shultz)]

@Jeff

Thanks! Submitted https://bugs.launchpad.net/kicad/+bug/1842108.