logClient falsely sends error logs on all connections

Bug #1841608 reported by Dirk Zimoch
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
EPICS Base
Status tracked in 7.0
3.15
Fix Released
Undecided
Unassigned
7.0
Fix Released
Undecided
Unassigned

Bug Description

Error messages generated with errlog and friends are sent to all logClients. This is wrong.
For example caPutLog uses the logClient facility. Its output to a log server should not be mixed with errlogs.

This bug had been introduced in commit ac2ff29a.

The fix moves errlog listener connection back from logClient to iocLog.

Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :
Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :

I will probably push a branch soon which addresses other problems with logClient.

Revision history for this message
Dirk Zimoch (dirk.zimoch) wrote :
Revision history for this message
Martin Konrad (info-martin-konrad) wrote :

This issue has been fixed by the following commit: https://git.launchpad.net/epics-base/commit/?id=62c3b0a585a4abcaae7794e487627bea29712be8 which got merged into the "7.0" branch here: https://git.launchpad.net/epics-base/commit/?id=fc04d1257875e6ca825deecf1b4d10d2d65b436a

If we don't want to fix this for 3.15 I think we can close this ticket.

Revision history for this message
Andrew Johnson (anj) wrote :

Why wouldn't we want this fix applied to the 3.15 branch? I just looked, and the commit that Dirk says introduced the bug was before 3.15.1.

Is our policy on fixing bugs not clear? We have always said that if they can be, bugs should normally be fixed in the earliest supported release that they were introduced in. If we don't do that, how can we claim that 3.15 is a "supported" release series?

I would like to not have to police this kind of thing myself — I didn't with the fixing of this bug earlier, and apparently that may have been a mistake.

Revision history for this message
Martin Konrad (info-martin-konrad) wrote :

I would appreciate if we could apply it to 3.15 as well. I was just confused by the fact that it was merged directly into 7.0 rather than into 3.15 and from there into 7.0. Anyway, I cherry-picked Dirks commits into a branch that can be merged into 3.15 (I had to fix the file names of some new files). MR is here:

https://code.launchpad.net/~info-martin-konrad/epics-base/+git/epics-base/+merge/375509

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.