[Ubuntu18.10][Backport] Crypto VMX Fixes

[bugproxy]

Cosmic is missing the fix for "5c380d623ed3 - crypto: vmx - Add support for VMS instructions by ASM (4 years, 5 months ago) <Leonidas S. Barbosa>" ... which is fixed by 'crypto: vmx - fix copy-paste error in CTR mode', it fixes a couple of incorrect branch targets, and usage of an incorrect vector assembly instruction.

The others two patches ("crypto: vmx - CTR: always increment IV as quadword ", "crypto: vmx - ghash: do nosimd fallback manually ") fixes for ghash replaces the fallback mechanism that is used on powerpc an operation is required to operate in interrupt context.

These fixes are important to avoid a potential data integrity issue.

[bugproxy (bugproxy)]

Default Comment by Bridge

[bugproxy (bugproxy)]

Default Comment by Bridge

[bugproxy (bugproxy)]

Default Comment by Bridge

[Andrew Cloke (andrew-cloke)]

Cosmic (18.10) is now end of life. It has been replaced by Disco (19.04). See https://wiki.ubuntu.com/Releases for further details.

Can this issue be closed?

[Frank Heimes (fheimes)]

As alreday mentioned in comment #4 18.10/cosmic reached it's EOL and one needs to migrate to disco:

So I just checked the situation on 19.04/disco.
In the current disco master two patches are in and two are out (as of today):
$ git log --oneline | grep -m 1 "Add support for VMS instructions by ASM"
5c380d6 crypto: vmx - Add support for VMS instructions by ASM
$ git log --oneline | grep -m 1 "fix copy-paste error in CTR mode"
6cef65e crypto: vmx - fix copy-paste error in CTR mode
$ git log --oneline | grep -m 1 "always increment IV as quadword"
$
$ git log --oneline | grep -m 1 "do nosimd fallback manually"
$

However disco master-next includes all patches (probably via a stable upstream release update):
$ git log --oneline | grep -m 1 "Add support for VMS instructions by ASM"
5c380d6 crypto: vmx - Add support for VMS instructions by ASM
$ git log --oneline | grep -m 1 "fix copy-paste error in CTR mode"
6cef65e crypto: vmx - fix copy-paste error in CTR mode
$ git log --oneline | grep -m 1 "always increment IV as quadword"
b5df7b3 crypto: vmx - CTR: always increment IV as quadword
$ git log --oneline | grep -m 1 "do nosimd fallback manually"
c438f2b crypto: vmx - ghash: do nosimd fallback manually

Hence I suggest to wait for the next and upcoming disco/19.10 kernel and close this LP once it got rolled out to the main pocket.

[Frank Heimes (fheimes)]

Closing this ticket (setting to Invalid, since it's about cosmic).
A new ticket got opened that addresses this issue specially for disco: LP 1841984
https://bugs.launchpad.net/ubuntu-power-systems/+bug/1841984