use [Library],GoToItem to trigger 'Close' in messages like "File not found"

[ronso0]

Currently, mouse or keyboard presses are the only way to close popup windows like error messages.
It would be way more convenient if we also could use [Library],GoToItem

[ronso0 (ronso0)]

my approach would be to filter for focusWidget class name 'QMessageBox' in /library/librarycontrol.cpp and map Up/Down key to emulate a Tab key, GoToItem would be spacebar

is there any quicker or more elegant solution?

[Daniel Schürmann (daschuer)]

I think the normal solution is for keyboard control, using Tab and Enter.

If we keep in line with it, it would be "[Library]", "MoveFocus"
Does it fit to your mapping? Does this already work?

If not, a cleaner solution would be so subclass 'QMessageBox' and handle the UP/Down keys there.

[Daniel Schürmann (daschuer)]

I think "[Library]", "MoveFocus" already works.

[ronso0 (ronso0)]

yes, also MoveUp/Down 'works' as it issues Tab to refocus the library.
The QToolButtons have focus and Enter or Spacebar would work.
To avoid any unexpected behaviour I'd like to make sure it's a QMessagebox we're in and not some library feature or other widget. How would I find out?
Would QApplication::activeModalWidget() or QApplication::activePopupWidget() be sufficient?

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/3199

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9727