Editor: Map saving can contain critical characters

[kaputtnik]

We have a check for safe filenames when saving a map. This check can be circumvented by:

1. Open editor
2. Open map options and give a non suspicious name (there is another bug here: The OK button is initially grayed out. If you delete ' Name' and write ' Name' again, the OK button is not grayed out)
3. Click OK
4. Open Save map menu
5. Click on Map Options
6. Add some bad characters to the map name, e.g.: \/,`?
7. Click OK

Result: The Filename in the Save Map screen has now the bad characters and the OK button is not grayed out -> Saving possible

If you enter the editbox of the filename (in Save Map screen) and delete the last bad character, the OK button get disabled.

When entering an exclamation mark (!) in step 6, the behavior is as expected: The OK button is disabled. I guess this is due my file system, which allows all characters except the exclamation mark.

[Toni Förster (stonerl)]

something like this would help:

https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/network/internet_gaming.cc#L1036

[GunChleoc (gunchleoc)]

We already have a filename check in place for saving a map, but it is only performed when typing in the editbox.

We should also double-check if we are catching those when saving a game.

IMO the internet gaming check is too restrictive here, because it excludes most languages other than English for filenames, which is not necessary.

[GunChleoc (gunchleoc)]

We also need to sanitize < and >.

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/215