Ember UI lacks consistency

Bug #184047 reported by Al Riddoch
2
Affects Status Importance Assigned to Milestone
Ember
Fix Released
Wishlist
Erik Ogenvik

Bug Description

There are a number of ways in which the Ember UI is not consistent. I will describe the inconsistencies with reference to the way I think the UI should work, though obviously this is opinion.

Typing text should always result in that text appearing in the chat text entry widget if that widget appears to have focus. If for any reason the state of the UI is such that pressing alphanumeric and other keys is not going to appear in the chat text entry widget, the widget should revert to its non-white state, and the text cursor should not be rendered. Ie. the widget should loose focus. Currently pressing the right button while the text widget has focus results in the mode changing back to using the keyboard for movement, but the text widget is still rendered as if it has focus.

Pressing the return key when the text widget does not have focus should always result in the text widget gaining focus, regardless of whether the client is in movement mode or not. This doesn't appear to work any way in either mode at the moment, though I thought we had discussed this feature earlier. The rational here is that there needs to be a very quick reliable way to switch in and out of chat, with minimal interference with movement.

Let me know your thoughts.

Changed in ember:
assignee: nobody → erik-hjortsberg
status: New → Confirmed
Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

Hmm, I've already added a comment to this one, but I guess Launchpad just ate it. So I'll redo it.

Thanks for your input!

You're totally right about how the window which has input should remove it when in movement mode, and regain it when switching back. I'll add that.

I think the discussion you refer to resulted in the way tab works: pressing tab will achieve exactly what you describe: you'll get switched to the gui mode and focused on the chat. You can get the same feature with the enter buttton by adding the following line to the "[key_bindings_movement]" section:
return = "/console_focus"

However, what happens then is that while you'll get switched to the chat window (since the Ember gui system listens for key presses) you'll immediately get switched back to the movement mode (since CEGUI listens for key release events (when the focus are on edit boxes at least) and if you press enter without having entered anything into the chat box you'll switch to movement mode automatically). I'll see how I can arrange for that to work better, since it would be more stringent, as you say, to get to the chat edit box by pressing enter, and to exit from there by pressing enter on an empty line.

Changed in ember:
importance: Undecided → Wishlist
milestone: none → 0.5.2
Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

I've now commited changes that:
1) deactivates the current input window when switching from input mode to movement mode, and reactivates it when switching back
2) fixes the problem with mapping /console_focus to enter, and maps enter to that command in movement mode by default

I'm not so sure about making it always enter the chat edit box when pressing enter even in input mode (when there's no active window).

Changed in ember:
status: Confirmed → Fix Committed
Changed in ember:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.