Selection in LibEdit selects elements in all units

[Seth Hillbrand]

Steps to reproduce:

1) Open LibEdit and load 74LS04 (Hex inverter)
2) Use mouse to draw a selection box around the visible elements in Unit A
3) Copy the selection and Paste again

At this point, you will have copies of all of the elements from all 7 units. The expected behavior is that we select only the visible elements in LibEdit.

Application: LibEdit
Version: (5.1.0-1515-gc2d77a730), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

[Rene Poeschl (poeschlr)]

Just to avoid misunderstandings:

Is this the symbol as found in the current master branch of the official lib (Meaning units A to G with unit G only for power pins) or do you possibly still have the old one without unit G and all units set to exchangeable (all units are not exchangeable deactivated) as well as all elements being set to "common to all units"? (This change was made when going over to v5 so i would guess you have the symbol with the separate power pin unit.)

[Seth Hillbrand (sethh)]

This is the version with separate power. The issue does not occur on symbols where all units are interchangeable (e.g. 74xx_IEEE:7404)

[Rene Poeschl (poeschlr)]

Is it the "all units are interchangeable" flag or is it the fact that the not affected symbol has its elements set to "all units"?

[Jeff Young (jeyjey)]

Interchangeability turned out to be a red herring. The reproducibility oddness was because the code was correct for pins, but not for other items.

[KiCad Janitor (kicad-janitor)]

Fixed in revision b4c8657904fec17fb99ef9f75e7f9f910849f0be
https://git.launchpad.net/kicad/patch/?id=b4c8657904fec17fb99ef9f75e7f9f910849f0be