kolla-ansible

Fluentd custom file not idempotent when overwriting default file

Bug #1840166 reported by Scott Solkhon on 2019-08-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	kolla-ansible	Fix Released	Medium	Scott Solkhon	kolla-ansible 9.0.0 "Train"
	Train	Fix Released	Medium	Scott Solkhon	kolla-ansible 9.0.0 "Train"

Bug Description

If we have a custom fluentd input/output/filter config with the same name as a
default config, we will first write out the default config then replace it with
the custom one, resulting in two changed tasks. This change fixes this by
skipping default configs that have been customised.

Tags:

Scott Solkhon (scott.solkhon) on 2019-08-14

Changed in kolla-ansible:
status:	New → In Progress
assignee:	nobody → Scott Solkhon (scott.solkhon)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-15: Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/676216
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=dcaa5f0b3d9953a562c55363b409bf5cb289f2bd
Submitter: Zuul
Branch: master

commit dcaa5f0b3d9953a562c55363b409bf5cb289f2bd
Author: Scott Solkhon <email address hidden>
Date: Tue Aug 13 15:22:37 2019 +0000

Fix idempotency of fluentd customisations

Fix fluentd config from overwriting custom config with the same filename

Closes-Bug: #1840166
Change-Id: I42c5446381033015f590901b2120950d602f847f

Changed in kolla-ansible:
status:	In Progress → Fix Released

Mark Goddard (mgoddard) on 2019-08-15

Changed in kolla-ansible:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-11-05: Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/693013

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-11-05: Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/693013
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=7e3021da8fe7c17ea833a55658c97c9ee0c93ae1
Submitter: Zuul
Branch: stable/stein

commit 7e3021da8fe7c17ea833a55658c97c9ee0c93ae1
Author: Scott Solkhon <email address hidden>
Date: Tue Aug 13 15:22:37 2019 +0000

Fix idempotency of fluentd customisations

Fix fluentd config from overwriting custom config with the same filename

    Closes-Bug: #1840166
    Change-Id: I42c5446381033015f590901b2120950d602f847f
    (cherry picked from commit dcaa5f0b3d9953a562c55363b409bf5cb289f2bd)