Choosing a pattern from a combo crashes Inkscape

[Alexandre Prokoudine]

Inkscape crashes, when you switch object's fill from flat/gradient to a pattern fille in the FIll and Stroke dialog and then try to pick an other pattern from the combo box.

Here goes gdb log:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb625e9f0 (LWP 19787)]
sp_pattern_painter_free (painter=0xcd0fde8) at ./uri-references.h:75
75 SPObject *getObject() const { return _obj; }
(gdb) bt
#0 sp_pattern_painter_free (painter=0xcd0fde8) at ./uri-references.h:75
#1 0x080dec2f in sp_painter_free (painter=0xcd0fde8) at sp-paint-server.cpp:141
#2 0x08351073 in nr_arena_shape_update (item=0xc0c2d48, area=0x0, gc=0xbfc717b8, state=<value optimized out>, reset=0) at display/nr-arena-shape.cpp:326
#3 0x08348cd4 in nr_arena_item_invoke_update (item=0xc0c2d48, area=0x0, gc=0xbfc71858, state=510, reset=<value optimized out>) at display/nr-arena-item.cpp:255
#4 0x0834aefd in nr_arena_group_update (item=0x94a3d00, area=0x0, gc=0xbfc718e8, state=510, reset=0) at display/nr-arena-group.cpp:175
#5 0x08348cd4 in nr_arena_item_invoke_update (item=0x94a3d00, area=0x0, gc=0xbfc71988, state=510, reset=<value optimized out>) at display/nr-arena-item.cpp:255
#6 0x0834aefd in nr_arena_group_update (item=0x94a3e00, area=0x0, gc=0xbfc71a18, state=510, reset=0) at display/nr-arena-group.cpp:175
#7 0x08348cd4 in nr_arena_item_invoke_update (item=0x94a3e00, area=0x0, gc=0xbfc71ab8, state=510, reset=<value optimized out>) at display/nr-arena-item.cpp:255
#8 0x0834aefd in nr_arena_group_update (item=0x94a3f00, area=0x0, gc=0xbfc71b48, state=510, reset=0) at display/nr-arena-group.cpp:175
#9 0x08348cd4 in nr_arena_item_invoke_update (item=0x94a3f00, area=0x0, gc=0x9434924, state=510, reset=<value optimized out>) at display/nr-arena-item.cpp:255
#10 0x08354e87 in sp_canvas_arena_update (item=0x9434880, affine=@0xbfc71c5c, flags=0) at display/canvas-arena.cpp:152
#11 0x08366a5f in sp_canvas_item_invoke_update (item=0x9434880, affine=<value optimized out>, flags=1) at display/sp-canvas.cpp:295
#12 0x0836a705 in sp_canvas_group_update (item=0x93ba1b0, affine=@0xbfc71e0c, flags=1) at display/sp-canvas.cpp:770
#13 0x08366a5f in sp_canvas_item_invoke_update (item=0x93ba1b0, affine=<value optimized out>, flags=1) at display/sp-canvas.cpp:295
#14 0x0836a705 in sp_canvas_group_update (item=0x93ba120, affine=@0xbfc71fbc, flags=1) at display/sp-canvas.cpp:770
#15 0x08366a5f in sp_canvas_item_invoke_update (item=0x93ba120, affine=<value optimized out>, flags=0) at display/sp-canvas.cpp:295
#16 0x08367a4b in do_update (canvas=0x8e03118) at display/sp-canvas.cpp:2022
#17 0x08158d72 in sp_document_maybe_done (doc=0x8965f50, key=0x0, event_type=167, event_description=@0xbfc721ac) at /usr/include/sigc++-2.0/sigc++/signal.h:550
#18 0x0815909c in sp_document_done (doc=0x8965f50, event_type=167, event_description=@0xbfc7220c) at document-undo.cpp:123
#19 0x08298b1d in sp_fill_style_widget_paint_changed (psel=0xcc28020, spw=0x9673a48) at dialogs/fill-style.cpp:513
#20 0xb73df1ef in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0
#21 0xb73d16f9 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#22 0xb73e74dd in ?? () from /usr/lib/libgobject-2.0.so.0
#23 0x095fb0b0 in ?? ()
#24 0x00000000 in ?? ()

[Ryan Lerch (ryanlerch)]

Works for me. Inkscape 0.46+devel (inkscape20080119rev17138AOCV.package) on fedora 8
Here was the sequence of events i tested:
1. Drew a rectangle
2. Opened Fill / Stroke Dialog box
3. Set the fill type to pattern
4. Changed the stock pattern from stripes 1:1 to checkerboard, and it worked as expected.

[joelholdsworth (joel-airwebreathe)]

I followed Ryan's steps on Ubuntu Gutsy. Same result - everything fine!

[Alexandre Prokoudine (alexandre-prokoudine)]

Ubuntu 8.04, still reproducible.

[bbyak (buliabyak)]

works for me too, please attach a file where it happens

[Alexandre Prokoudine (alexandre-prokoudine)]

Reproducible on any new document for me.

[bbyak (buliabyak)]

still cannot repro with attached file - linux r17178

[bbyak (buliabyak)]

just speculating, try adding

 pp->pat = NULL;

before line 814 in sp-pattern.cpp and see if it helps

[Maarten Maathuis (madman2003)]

I also have this problem, if you need any test victims.

[bbyak (buliabyak)]

Maarten: so can you try the fix I proposed above?

[Maarten Maathuis (madman2003)]

It doesn't fix it.

[ScislaC (scislac)]

Weird... I get the crash too when choosing patterns from the combo box as well. SVN rev 17396, and this was built clean. I'm also on Ubuntu 8.04 (Hardy).

Given that this version will be the one in Hardy, it's a somewhat nasty crasher to have (with data loss no less). The only thing I can guess is that it's potentially related to libraries.

-Josh

[Bryce Harrington (bryce)]

I can confirm this on Ubuntu Hardy both with current svn head, and with the preview release uploaded to Hardy. I cannot reproduce it on Gutsy with current svn head.

Could it be a library bug?

[bbyak (buliabyak)]

So, can anyone on Hardy please debug and fix this? I cannot reproduce this on my OS and so cannot fix.

[Guillermo Espertino (Gez) (gespertino-gmail)]

I can't reproduce it in Hardy (64bit) with SVN rev. 20045.
Works fine here.

[bbyak (buliabyak)]

Thanks Guillermo, anyone else can reproduce it with current svn anywhere? Bryce? If not we'll close this.

[Alexandre Prokoudine (alexandre-prokoudine)]

Can't reproduce it

[Paolo Crosetto (paolo-crosetto)]

I have the same bug here. Not using svn, but (I guess) latest update from OpenSuse repos.

when applying a pattern fill to any shape, object or else, everything is fine; when trying to select another fill from the list, inkscape crashes. Stars, circles, path, wathever: they all crash at the very same point.

System:
Linux 2.6.22.19-0.1-bigsmp #1 SMP 2008-10-14 22:17:43 +0200 i686 i686 i386 GNU/Linux
OpenSuse 10.3
Kde 3.5.10-2.2

here you have the gbt output:

(gdb) bt
#0 0x080e5bd5 in sp_pattern_painter_free ()
#1 0x080e39ff in sp_painter_free ()
#2 0x083c6275 in nr_arena_shape_update ()
#3 0x083bdf84 in nr_arena_item_invoke_update ()
#4 0x083c01ad in nr_arena_group_update ()
#5 0x083bdf84 in nr_arena_item_invoke_update ()
#6 0x083c01ad in nr_arena_group_update ()
#7 0x083bdf84 in nr_arena_item_invoke_update ()
#8 0x083c01ad in nr_arena_group_update ()
#9 0x083bdf84 in nr_arena_item_invoke_update ()
#10 0x083ca077 in sp_canvas_arena_update ()
#11 0x083dbdbf in sp_canvas_item_invoke_update ()
#12 0x083dfb27 in sp_canvas_group_update ()
#13 0x083dbdbf in sp_canvas_item_invoke_update ()
#14 0x083dfb27 in sp_canvas_group_update ()
#15 0x083dbdbf in sp_canvas_item_invoke_update ()
#16 0x083dce0b in do_update ()
#17 0x0815a2a4 in sp_document_maybe_done ()
#18 0x0815a5cc in sp_document_done ()
#19 0x082a84cd in sp_fill_style_widget_paint_changed ()
#20 0xb763d52f in g_cclosure_marshal_VOID__VOID ()
   from /usr/lib/libgobject-2.0.so.0
#21 0xb762fac9 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
---Type <return> to continue, or q <return> to quit---
#22 0xb76457bd in signal_emit_unlocked_R () from /usr/lib/libgobject-2.0.so.0
(gdb)

[bbyak (buliabyak)]

marking as fixed since the original reporter can't reproduce

Paolo, your build is likely old - if you can reproduce with latest svn, please reopen

[bbyak (buliabyak)]

ok, now with gtk update i was finally able to reproduce it, and fixed it properly.