"Sync cached facts" task fails on dry-run

[Emilien Macchi]

ry-run fails on TASK [Sync cached facts]:

TASK [Sync cached facts] *******************************************************
fatal: [controller-1 -> 192.168.24.7]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}

The task shouldn't try to do actual rsyncs, we should skip it.

[Emilien Macchi (emilienm)]

Logs from a dry-run:

TASK [Create puppet caching structures] ****************************************
changed: [controller-0]
changed: [controller-1]
changed: [controller-2]
changed: [compute-0]
changed: [compute-1]

TASK [Write facter cache config] ***********************************************
changed: [controller-0]
changed: [controller-1]
changed: [controller-2]
changed: [compute-0]
changed: [compute-1]

TASK [Cleanup facter cache if exists] ******************************************
ok: [controller-0]
ok: [controller-1]
ok: [controller-2]
ok: [compute-0]
ok: [compute-1]

TASK [Pre-cache facts] *********************************************************
skipping: [controller-0]
skipping: [controller-1]
skipping: [controller-2]
skipping: [compute-0]
skipping: [compute-1]

TASK [Sync cached facts] *******************************************************
fatal: [controller-1 -> 192.168.24.7]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}
fatal: [controller-0 -> 192.168.24.19]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}
fatal: [controller-2 -> 192.168.24.21]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}
fatal: [compute-0 -> 192.168.24.17]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}
fatal: [compute-1 -> 192.168.24.12]: FAILED! => {"changed": false, "cmd": "/bin/rsync --delay-updates -F --compress --dry-run --archive --out-format=<<CHANGED>>%i %n%L /opt/puppetlabs/ /var/lib/container-puppet/puppetlabs/", "msg": "rsync: change_dir \"/opt/puppetlabs\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1189) [sender=3.1.3]\n", "rc": 23}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/675108

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/675621

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/675622

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/675623

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675108
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9581614e9353576c6a7b83136793631473851b31
Submitter: Zuul
Branch: master

commit 9581614e9353576c6a7b83136793631473851b31
Author: Emilien Macchi <email address hidden>
Date: Wed Aug 7 08:33:34 2019 -0400

    Force "Pre-cache" tasks to run in dry run

    We don't want the pre-cache tasks to be skipped in dry-run so we force
    check_mode to "no".

    For example, "command" is skipped in check mode because we don't provide
    "creates" nor "removes"; and since we need to cache facts when running Puppet
    in dry mode, we need to make sure this task is run anyway.

    See https://docs.ansible.com/ansible/latest/modules/command_module.html

    For "file", "copy", and "synchronize", they aren't skipped in dry mode
    but the resources aren't executed for real.

    So this patch disable check_mode for all these tasks.
    We also move the tasks in a block which avoid tags & check_mode
    duplication for each task and avoid problems in the future if a task is
    added.

    Closes-Bug: #1839321
    Change-Id: I21524419b8b416d0879fc61aa3274d2e30537438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675621
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d191423e86512e6101523ccea23f7f47e21087dd
Submitter: Zuul
Branch: stable/stein

commit d191423e86512e6101523ccea23f7f47e21087dd
Author: Emilien Macchi <email address hidden>
Date: Wed Aug 7 08:33:34 2019 -0400

    Force "Pre-cache" tasks to run in dry run

    We don't want the pre-cache tasks to be skipped in dry-run so we force
    check_mode to "no".

    For example, "command" is skipped in check mode because we don't provide
    "creates" nor "removes"; and since we need to cache facts when running Puppet
    in dry mode, we need to make sure this task is run anyway.

    See https://docs.ansible.com/ansible/latest/modules/command_module.html

    For "file", "copy", and "synchronize", they aren't skipped in dry mode
    but the resources aren't executed for real.

    So this patch disable check_mode for all these tasks.
    We also move the tasks in a block which avoid tags & check_mode
    duplication for each task and avoid problems in the future if a task is
    added.

    Closes-Bug: #1839321
    Change-Id: I21524419b8b416d0879fc61aa3274d2e30537438
    (cherry picked from commit 9581614e9353576c6a7b83136793631473851b31)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675623
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6eb1048e303a1b4d530e47fb89d9c2460a7668f7
Submitter: Zuul
Branch: stable/queens

commit 6eb1048e303a1b4d530e47fb89d9c2460a7668f7
Author: Emilien Macchi <email address hidden>
Date: Wed Aug 7 08:33:34 2019 -0400

    Force "Pre-cache" tasks to run in dry run

    We don't want the pre-cache tasks to be skipped in dry-run so we force
    check_mode to "no".

    For example, "command" is skipped in check mode because we don't provide
    "creates" nor "removes"; and since we need to cache facts when running Puppet
    in dry mode, we need to make sure this task is run anyway.

    See https://docs.ansible.com/ansible/latest/modules/command_module.html

    For "file", "copy", and "synchronize", they aren't skipped in dry mode
    but the resources aren't executed for real.

    So this patch disable check_mode for all these tasks.
    We also move the tasks in a block which avoid tags & check_mode
    duplication for each task and avoid problems in the future if a task is
    added.

    Closes-Bug: #1839321
    Change-Id: I21524419b8b416d0879fc61aa3274d2e30537438
    (cherry picked from commit 9581614e9353576c6a7b83136793631473851b31)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675622
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d65795e1ea9e857fd28082befb2b61916fc92817
Submitter: Zuul
Branch: stable/rocky

commit d65795e1ea9e857fd28082befb2b61916fc92817
Author: Emilien Macchi <email address hidden>
Date: Wed Aug 7 08:33:34 2019 -0400

    Force "Pre-cache" tasks to run in dry run

    We don't want the pre-cache tasks to be skipped in dry-run so we force
    check_mode to "no".

    For example, "command" is skipped in check mode because we don't provide
    "creates" nor "removes"; and since we need to cache facts when running Puppet
    in dry mode, we need to make sure this task is run anyway.

    See https://docs.ansible.com/ansible/latest/modules/command_module.html

    For "file", "copy", and "synchronize", they aren't skipped in dry mode
    but the resources aren't executed for real.

    So this patch disable check_mode for all these tasks.
    We also move the tasks in a block which avoid tags & check_mode
    duplication for each task and avoid problems in the future if a task is
    added.

    Closes-Bug: #1839321
    Change-Id: I21524419b8b416d0879fc61aa3274d2e30537438
    (cherry picked from commit 9581614e9353576c6a7b83136793631473851b31)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.2.0 release.