Email info out of sync

[Cecilia Vela Gurovic]

When adding a non-primary email via:
 set_profile_field($userid, 'email', $email, TRUE);

we shouldn't set email field in usr table to this new email address
as the usr.email should be the primary address one

[Cecilia Vela Gurovic (ceciliavg)]

https://reviews.mahara.org/#/c/10148/

[Steven (stevens-q)]

Commit hash: c8895712d2053467508c0602421c9cf8b73953d9
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara User19 exists (no roles) (db user ID=20)
2) The following lines of code were added to dummy.php in htdocs to generate emails
<?php
/**
 *
 * @package mahara
 * @subpackage core
 * @author Catalyst IT Ltd
 * @license http://www.gnu.org/copyleft/gpl.html GNU GPL version 3 or later
 * @copyright For copyright information on Mahara, please see the README file distributed with this software.
 *
 */

define('INTERNAL', 1);
require('init.php');

if ($USER->is_logged_in()) {
    // we are returning from the SAMl check
    $dummy_username = 'steven' . rand(10000,99999);
    $dummy_email = $dummy_username . '@catalyst.net.nz';

    // set email as non-primary
    set_profile_field($USER->get('id'), 'email', $dummy_email, true);
    $fullname = display_name($USER, null, true);

    $SESSION->add_ok_msg('Add email for ' . $fullname . ' as ' . $dummy_email);
    redirect('/');
}
3) Main URL = http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz

TEST STEPS:
------------------------
1) Log in as Mahara User19
2) Browse to /dummy.php
3) Verify that a success message is displayed "Add email for Steve User19 as <email address hidden>"
4) Browse to /artefact/internal/index.php
5) Verify that the new email address has been added to the users profile addresses
6) Set the new eamil to the default /primary email
7) Browse to the database table - artefact_internal_profile_email
8) Verify that user ID 20 displays the new email and that the principle column is set to 1
9) Verify that user ID 20 displays the old email and that the principle column is set to 0

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10148
Committed: https://git.mahara.org/mahara/mahara/commit/0cd7ed99a5e73fdc9a648ceb2162dc055fce143e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0cd7ed99a5e73fdc9a648ceb2162dc055fce143e
Author: Robert Lyon <email address hidden>
Date: Mon Jul 8 09:01:32 2019 +1200

Bug 1838908: Email info out of sync

When adding a non-primary email via:
set_profile_field($userid, 'email', $email, TRUE);

we shouldn't set email field in usr table to this new email address
as the usr.email should be the primary address one

Change-Id: Id8e780f3d7efa3baaae6383932e825a9cceb5e46
Signed-off-by: Robert Lyon <email address hidden>