config download uses expensive api calls for deployment_name

Bug #1838861 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Rabi Mishra

Bug Description

https://github.com/openstack/tripleo-common/blob/master/tripleo_common/utils/config.py#L357-L360

For every deployment resource we filter all resources of overcloud with a non-indexed field 'physical_resource_id' in the api call to get the deployment name. This is really inefficient and would take ages when there are large number of nodes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/674476

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
milestone: none → train-3
tags: added: queens-backport-potential rocky-backport-potential stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/674476
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=3df3719e82bedb0a167d5b981668403e2bd4e316
Submitter: Zuul
Branch: master

commit 3df3719e82bedb0a167d5b981668403e2bd4e316
Author: Rabi Mishra <email address hidden>
Date: Sun Aug 4 05:33:19 2019 +0530

    Fix expensive api call to get deployment_name

    We filter all resources for overcloud root stack with a
    non-indexed field 'physical_resource_id' (nova_instance).
    This is very inefficient.

    With this patch, though there would still be making heat api
    calls for every deployment, it won't be so expensive.

    Change-Id: I260501e6061c0d6652b22504e7284940b2c64709
    Closes-Bug: #1838861

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/674582

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/674583

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/674584

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.opendev.org/674584
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e3ca555245cf2a6eec22d3473a3ea2dc4538bbb6
Submitter: Zuul
Branch: stable/queens

commit e3ca555245cf2a6eec22d3473a3ea2dc4538bbb6
Author: Rabi Mishra <email address hidden>
Date: Sun Aug 4 05:33:19 2019 +0530

    Fix expensive api call to get deployment_name

    We filter all resources for overcloud root stack with a
    non-indexed field 'physical_resource_id' (nova_instance).
    This is very inefficient.

    With this patch, though there would still be making heat api
    calls for every deployment, it won't be so expensive.

    Change-Id: I260501e6061c0d6652b22504e7284940b2c64709
    Closes-Bug: #1838861
    (cherry picked from commit 3df3719e82bedb0a167d5b981668403e2bd4e316)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/stein)

Reviewed: https://review.opendev.org/674582
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=142ae92f8ba20e1dfca811182d92f74553cb546d
Submitter: Zuul
Branch: stable/stein

commit 142ae92f8ba20e1dfca811182d92f74553cb546d
Author: Rabi Mishra <email address hidden>
Date: Sun Aug 4 05:33:19 2019 +0530

    Fix expensive api call to get deployment_name

    We filter all resources for overcloud root stack with a
    non-indexed field 'physical_resource_id' (nova_instance).
    This is very inefficient.

    With this patch, though there would still be making heat api
    calls for every deployment, it won't be so expensive.

    Change-Id: I260501e6061c0d6652b22504e7284940b2c64709
    Closes-Bug: #1838861
    (cherry picked from commit 3df3719e82bedb0a167d5b981668403e2bd4e316)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.opendev.org/674583
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=652aad411fe217247b5612b533a9a5a1ff1aa013
Submitter: Zuul
Branch: stable/rocky

commit 652aad411fe217247b5612b533a9a5a1ff1aa013
Author: Rabi Mishra <email address hidden>
Date: Sun Aug 4 05:33:19 2019 +0530

    Fix expensive api call to get deployment_name

    We filter all resources for overcloud root stack with a
    non-indexed field 'physical_resource_id' (nova_instance).
    This is very inefficient.

    With this patch, though there would still be making heat api
    calls for every deployment, it won't be so expensive.

    Change-Id: I260501e6061c0d6652b22504e7284940b2c64709
    Closes-Bug: #1838861
    (cherry picked from commit 3df3719e82bedb0a167d5b981668403e2bd4e316)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.8.1

This issue was fixed in the openstack/tripleo-common 10.8.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.6.1

This issue was fixed in the openstack/tripleo-common 9.6.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.7.1

This issue was fixed in the openstack/tripleo-common 8.7.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 11.2.0

This issue was fixed in the openstack/tripleo-common 11.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.