enable_telemetry=false in undercloud.conf doesn't set notification_driver to noop

[David Hill]

setting enable_telemetry=false in undercloud.conf and running 'openstack undercloud install' doesn't set notification_driver to noop as it is hardcoded to messaging in the puppet template file.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/674639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/674639
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0faa33a6b07f711054ebd8deeaad34a1704745b6
Submitter: Zuul
Branch: master

commit 0faa33a6b07f711054ebd8deeaad34a1704745b6
Author: Alex Schultz <email address hidden>
Date: Mon Aug 5 09:49:57 2019 -0600

    Disable telemetry if it's not enabled

    The disable-telemetry.yaml environment is used to disable all the
    telemetry services and to disable the notification drivers. Since we
    didn't have this by default, notifications were still being sent to
    the undercloud rabbitmq and never consumed.

    Change-Id: I53eab2c41c80f5dafff9824bf3086e1d9a369e22
    Closes-Bug: #1838828

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/675114

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/675116

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675114
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d5edfc3aeab96958cc7e5bac2184dd24a3aed037
Submitter: Zuul
Branch: stable/stein

commit d5edfc3aeab96958cc7e5bac2184dd24a3aed037
Author: Alex Schultz <email address hidden>
Date: Mon Aug 5 09:49:57 2019 -0600

    Disable telemetry if it's not enabled

    The disable-telemetry.yaml environment is used to disable all the
    telemetry services and to disable the notification drivers. Since we
    didn't have this by default, notifications were still being sent to
    the undercloud rabbitmq and never consumed.

    Conflicts:
     tripleoclient/tests/v1/undercloud/test_install_upgrade.py

    Change-Id: I53eab2c41c80f5dafff9824bf3086e1d9a369e22
    Closes-Bug: #1838828
    (cherry picked from commit 0faa33a6b07f711054ebd8deeaad34a1704745b6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675116
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=2e0b581f728c4d744793e96bf85954fab98f75fa
Submitter: Zuul
Branch: stable/rocky

commit 2e0b581f728c4d744793e96bf85954fab98f75fa
Author: Alex Schultz <email address hidden>
Date: Mon Aug 5 09:49:57 2019 -0600

    Disable telemetry if it's not enabled

    The disable-telemetry.yaml environment is used to disable all the
    telemetry services and to disable the notification drivers. Since we
    didn't have this by default, notifications were still being sent to
    the undercloud rabbitmq and never consumed.

    Conflicts:
     tripleoclient/tests/v1/undercloud/test_undercloud.py

    Change-Id: I53eab2c41c80f5dafff9824bf3086e1d9a369e22
    Closes-Bug: #1838828
    (cherry picked from commit 0faa33a6b07f711054ebd8deeaad34a1704745b6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/674160
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=8b6d68d13fab7cf28388d7e48f2b89be2c8932e8
Submitter: Zuul
Branch: stable/rocky

commit 8b6d68d13fab7cf28388d7e48f2b89be2c8932e8
Author: David Hill <email address hidden>
Date: Thu Aug 1 22:52:59 2019 -0400

    Set notification driver to noop when enable_telemetry=false

    Actually, enable_telemetry=false doesn't do anything because
    the notification_drivers values are hardcoded to messaging.
    This commit changes this behavior by setting notification_drivers
    to noop if enable_telemetry is set to false.

    Change-Id: I75441352c29b0421358fc0c87f8708355e7fbb2a
    Closes-bug: #1838828
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/676821

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676821
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=3e1125cc7266afb938965d07f1c4341cde685e0a
Submitter: Zuul
Branch: stable/queens

commit 3e1125cc7266afb938965d07f1c4341cde685e0a
Author: David Hill <email address hidden>
Date: Thu Aug 1 22:52:59 2019 -0400

    Set notification driver to noop when enable_telemetry=false

    Actually, enable_telemetry=false doesn't do anything because
    the notification_drivers values are hardcoded to messaging.
    This commit changes this behavior by setting notification_drivers
    to noop if enable_telemetry is set to false.

    Conflicts:
     elements/puppet-stack-config/puppet-stack-config.yaml.template

    Change-Id: I75441352c29b0421358fc0c87f8708355e7fbb2a
    Closes-bug: #1838828
    Co-Authored-By: Alex Schultz <email address hidden>
    (cherry picked from commit 8b6d68d13fab7cf28388d7e48f2b89be2c8932e8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 9.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.7.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.4.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.