Deployment workflow doesn't entertain ansible_python_interpreter input

[yatin]

Detected while testing deployment with python3.

Issue is overcloud deploy --deployment-python-interpreter /usr/bin/python3 doesn't correctly set ansible_python_interpreter in generated inventory file.

This is happening because deployment_options are not passed to generate_inventory task https://github.com/openstack/tripleo-common/blob/09a6c163eeb51ff8e70d0b0a6fda63fffc8467b3/workbooks/deployment.yaml#L493

and secondly it's not passed to config-download deployment:-
https://github.com/openstack/python-tripleoclient/blob/c3fb3cb6622dbf7dd577578a55999954d544265a/tripleoclient/v1/overcloud_deploy.py#L989-L997
https://github.com/openstack/python-tripleoclient/blob/c3fb3cb6622dbf7dd577578a55999954d544265a/tripleoclient/workflows/deployment.py#L327

Actual Result:-
- ansible_python_interpreter is not set for overcloud nodes in generated inventory file

Expected Result:-
- ansible_python_interpreter should be set correctly for overcloud nodes in generated inventory file.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/673862

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/673868

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673862
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=71b285b345bd3240450cacc7047d0184dc415102
Submitter: Zuul
Branch: master

commit 71b285b345bd3240450cacc7047d0184dc415102
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:24:50 2019 +0530

    Add deployment_options input to config_download workflow

    Inventory is generated as a part of config_download_deploy
    workflow but 'deployment_options' input needed to set
    'ansible_python_interpreter' input for 'ansible-generate-inventory'
    action is missing as a input to the workflow.
    This patch adds it.

    Partial-Bug: #1838540
    Change-Id: I86b914f8e20704da2d566d137718b4b7fb02ad95

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673868
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ac7ae9e8d638676196c4897a30c978d51a091900
Submitter: Zuul
Branch: master

commit ac7ae9e8d638676196c4897a30c978d51a091900
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:39:38 2019 +0530

    Pass deployment_options to config download

    https://review.opendev.org/673862 allows config_download
    workflow to take deployment_options as a input, this patch
    passes it to the workflow so ansible_python_interpreter
    is set correctly in generated inventory and thus used
    during ansible deployment.

    Depends-On: https://review.opendev.org/#/c/673862/
    Closes-Bug: #1838540
    Change-Id: I993fc09fd571fb93d78ffdbecf1823e806f744f4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/675804

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/675817

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675804
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=60539b3a85e889f3b2fc6b3a674916e0308178f8
Submitter: Zuul
Branch: stable/stein

commit 60539b3a85e889f3b2fc6b3a674916e0308178f8
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:24:50 2019 +0530

    Add deployment_options input to config_download workflow

    Inventory is generated as a part of config_download_deploy
    workflow but 'deployment_options' input needed to set
    'ansible_python_interpreter' input for 'ansible-generate-inventory'
    action is missing as a input to the workflow.
    This patch adds it.

    Partial-Bug: #1838540
    Change-Id: I86b914f8e20704da2d566d137718b4b7fb02ad95
    (cherry picked from commit 71b285b345bd3240450cacc7047d0184dc415102)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675817
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=17079abbbbad82322f5326d4ea50c474349eefae
Submitter: Zuul
Branch: stable/stein

commit 17079abbbbad82322f5326d4ea50c474349eefae
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:39:38 2019 +0530

    Pass deployment_options to config download

    https://review.opendev.org/673862 allows config_download
    workflow to take deployment_options as a input, this patch
    passes it to the workflow so ansible_python_interpreter
    is set correctly in generated inventory and thus used
    during ansible deployment.

    Depends-On: https://review.opendev.org/#/c/675804/
    Closes-Bug: #1838540
    Change-Id: I993fc09fd571fb93d78ffdbecf1823e806f744f4
    (cherry picked from commit ac7ae9e8d638676196c4897a30c978d51a091900)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.