tripleo.ansible-generate-inventory action broken with ansible_python_interpreter

[yatin]

tripleo.ansible-generate-inventory action Errors when input contains ansible_python_interpreter.

Detected while trying overcloud deployment on Fedora28.

Simple reproducer:-
mistral run-action tripleo.ansible-generate-inventory '{"ansible_ssh_user": "tripleo-admin", "work_dir": "/var/lib/mistral/test", "plan_name": "overcloud", "ssh_network": "ctlplane", "undercloud_key_file": "/var/lib/mistral/.ssh/tripleo-admin-rsa", "ansible_python_interpreter": "python3"}'

Issue is https://github.com/openstack/tripleo-common/blob/09a6c163eeb51ff8e70d0b0a6fda63fffc8467b3/tripleo_common/inventory.py#L329 role --> service.lower().

Unit test were also missing for this part. So that also need to be added.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673850
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6a35576e9e6154a33e64413750e9da01603b7722
Submitter: Zuul
Branch: master

commit 6a35576e9e6154a33e64413750e9da01603b7722
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:01:05 2019 +0530

    Fix ansible-generate-inventory action

    ansible-generate-inventory action raises Exception
    when 'ansible_python_interpreter' input is passed to it.

    This patch fixes it and also update unit test to cover
    missing part.

    Closes-Bug: #1838536
    Change-Id: Ie41ba6de1170a9c9ffc94889e47bce9ef1200521

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/674293

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/674293
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=df8f0243d0cb52806a05a8aff6dfdd9c875f02d9
Submitter: Zuul
Branch: stable/stein

commit df8f0243d0cb52806a05a8aff6dfdd9c875f02d9
Author: yatinkarel <email address hidden>
Date: Wed Jul 31 21:01:05 2019 +0530

    Fix ansible-generate-inventory action

    ansible-generate-inventory action raises Exception
    when 'ansible_python_interpreter' input is passed to it.

    This patch fixes it and also update unit test to cover
    missing part.

    Adjusts Unit test for stable/stein as [1] is not in
    stable/stein.

    [1] https://review.opendev.org/#/c/663466/

    Closes-Bug: #1838536
    Depends-On: https://review.opendev.org/#/c/674530/
    Change-Id: Ie41ba6de1170a9c9ffc94889e47bce9ef1200521
    (cherry picked from commit 6a35576e9e6154a33e64413750e9da01603b7722)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.8.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.2.0 release.