tripleoclient unit tests fail intermitently at packaging (again)

[Javier Peña]

We are seeing the same symptoms from https://bugs.launchpad.net/bugs/1775577 again, now with the following stack trace:

==============================
Failed 1 tests - output below:
==============================
tripleoclient.tests.v1.overcloud_upgrade.test_overcloud_upgrade.TestOvercloudUpgradePrepare.test_upgrade_out
------------------------------------------------------------------------------------------------------------
Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/usr/lib/python3.6/site-packages/mock/mock.py", line 1330, in patched'
    b' return func(*args, **keywargs)'
    b' File "/builddir/build/BUILD/python-tripleoclient-12.1.1.dev11/tripleoclient/tests/v1/overcloud_upgrade/test_overcloud_upgrade.py", line 85, in test_upgrade_out'
    b' self.cmd.take_action(parsed_args)'
    b' File "/builddir/build/BUILD/python-tripleoclient-12.1.1.dev11/tripleoclient/v1/overcloud_upgrade.py", line 74, in take_action'
    b' super(UpgradePrepare, self).take_action(parsed_args)'
    b' File "/builddir/build/BUILD/python-tripleoclient-12.1.1.dev11/tripleoclient/v1/overcloud_deploy.py", line 957, in take_action'
    b' self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)'
    b' File "/builddir/build/BUILD/python-tripleoclient-12.1.1.dev11/tripleoclient/v1/overcloud_deploy.py", line 363, in _deploy_tripleo_heat_templates_tmpdir'
    b" tht_tmp = tempfile.mkdtemp(prefix='tripleoclient-')"
    b' File "/usr/lib64/python3.6/tempfile.py", line 360, in mkdtemp'
    b' prefix, suffix, dir, output_type = _sanitize_params(prefix, suffix, dir)'
    b' File "/usr/lib64/python3.6/tempfile.py", line 130, in _sanitize_params'
    b' dir = gettempdir()'
    b' File "/usr/lib64/python3.6/tempfile.py", line 298, in gettempdir'
    b' tempdir = _get_default_tempdir()'
    b' File "/usr/lib64/python3.6/tempfile.py", line 233, in _get_default_tempdir'
    b' dirlist)'
    b"FileNotFoundError: [Errno 2] No usable temporary directory found in ['/tmp', '/var/tmp', '/usr/tmp', '/builddir/build/BUILD/python-tripleoclient-12.1.1.dev11']"
    b''

This has started happening after https://review.opendev.org/670091 was merged, and is preventing downstream tripleoclient builds from succeeding.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/673828

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673828
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e1cb3042c8fe25d7fe28bc7d1d38f5a3ae90fa1d
Submitter: Zuul
Branch: master

commit e1cb3042c8fe25d7fe28bc7d1d38f5a3ae90fa1d
Author: Gael Chamoulaud <email address hidden>
Date: Wed Jul 31 16:06:28 2019 +0200

    Mock deployment action in upgrade tests

    Without properly mocking the deployment action, these tests are trying
    to execute deployment code including temp file creation which can lead
    to package build failures. This change mocks out the deployment take
    action for the UpgradeRun so we're only testing the upgrade code
    itself.

    Change-Id: I3ac295d2e2f86fbb2120f9491d4103434b6ac3da
    Closes-Bug: #1838506
    Signed-off-by: Gael Chamoulaud <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/673986

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673986
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=38070104592d6ad6e15a184df64bbb0d48858f25
Submitter: Zuul
Branch: stable/stein

commit 38070104592d6ad6e15a184df64bbb0d48858f25
Author: Gael Chamoulaud <email address hidden>
Date: Wed Jul 31 16:06:28 2019 +0200

    Mock deployment action in upgrade tests

    Without properly mocking the deployment action, these tests are trying
    to execute deployment code including temp file creation which can lead
    to package build failures. This change mocks out the deployment take
    action for the UpgradeRun so we're only testing the upgrade code
    itself.

    Change-Id: I3ac295d2e2f86fbb2120f9491d4103434b6ac3da
    Closes-Bug: #1838506
    Signed-off-by: Gael Chamoulaud <email address hidden>
    (cherry picked from commit e1cb3042c8fe25d7fe28bc7d1d38f5a3ae90fa1d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.