Some menubar menu separators got lost

Bug #1838422 reported by Michael Kavanagh
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Michael Kavanagh

Bug Description

Comparing menubar between 5.1 and master, looks like some separators got lost in the transition to ACTION based menus.

Application: KiCad
Version: (5.1.0-1387-g6bf1ac45e-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.70.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :
Changed in kicad:
status: Triaged → Fix Committed
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

Sorry, forgot the "Fixes:" line. Fixed in 58cfc136499c370815f1a0794bbe421752da0d3c.

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

Thanks for committing JP, but I missed a couple in the 3D viewer. Sorry!

Changed in kicad:
status: Fix Committed → In Progress
tags: added: 3d-viewer
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 300fb43a38699f066e0dc8ec781f5b3a7f52c1eb
https://git.launchpad.net/kicad/patch/?id=300fb43a38699f066e0dc8ec781f5b3a7f52c1eb

Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.