Footprint editor <PgUp>,<PgDn> keys do not update display

[Stephen]

I have a footprint which includes
    F.Mask
    B.Cu

F.Mask hides B.Cu.
To see B.Cu, I have to un-check the F.Mask checkbox.

( However, in PcbNew, I merely press <PgDn> )
-------------------------------

      Application: pcbnew
      Version: (5.1.2)-2, release build
      Libraries:
          wxWidgets 3.0.4
          libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
      Platform: Windows 7 (build 7601, Service Pack 1), 32 bit, Little endian, wxMSW
      Build Info:
          wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
          Boost: 1.68.0
          OpenCASCADE Community Edition: 6.9.1
          Curl: 7.61.1
          Compiler: GCC 7.3.0 with C++ ABI 1011

      Build settings:
          USE_WX_GRAPHICS_CONTEXT=OFF
          USE_WX_OVERLAY=OFF
          KICAD_SCRIPTING=ON
          KICAD_SCRIPTING_MODULES=ON
          KICAD_SCRIPTING_PYTHON3=OFF
          KICAD_SCRIPTING_WXPYTHON=ON
          KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
          KICAD_SCRIPTING_ACTION_MENU=ON
          BUILD_GITHUB_PLUGIN=ON
          KICAD_USE_OCE=ON
          KICAD_USE_OCC=OFF
          KICAD_SPICE=ON
-------------------------------

[Ian McInerney (imcinerney)]

@Michael, this is not a duplicate of that bug.

The hotkey is working as expected; it is changing the active layer, but you can only see that when you start drawing something. What is broken is that the layer change is not actually updating the display to show the layer has been changed. The footprint editor will need its equivalent of the PCB_EDIT_FRAME::SetActiveLayer function, and to override the SwitchLayer function in the base frame to use it and perform the needed checks.

[Ian McInerney (imcinerney)]

Or at least that is the case in master, in 5.1 the layer switch keys do not have any effect all in the footprint editor.

[Michael Kavanagh (michaelkavanagh)]

@Ian, my bad, I assumed this had been fixed by the bug I linked. Sorry!

[KiCad Janitor (kicad-janitor)]

Fixed in revision 494d0de9b8565bd1e12a3704f887410b76128603
https://git.launchpad.net/kicad/patch/?id=494d0de9b8565bd1e12a3704f887410b76128603