Unnecessary checks on Simulation.Timetable

Bug #1838233 reported by r.roeterdink
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Undecided
r.roeterdink

Bug Description

There are a number of unnecessary checks on Simulation.Timetable in Signals.cs.

These checks are not required because :
 - other checks in the relevant 'if' statement are such that they can either only occur if Simulation.Timetable is true of if Simulation.Timetable is false
 - the method called following the 'if' statement has separate instances for classes Train.cs and TTTrain.cs

Revision history for this message
r.roeterdink (r-roeterdink) wrote :

The superflous checks have been removed.
In one situation (method GetSectionStateClearNode), a new instanced method (TrainGetSectionStateClearNode) has been created to remove the need for the 'if' statement.

Changed in or:
status: New → In Progress
assignee: nobody → r.roeterdink (r-roeterdink)
Changed in or:
status: In Progress → Fix Committed
James Ross (twpol)
Changed in or:
milestone: none → 1.4
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.