angular: .editorconfig specifies the wrong number of spaces

Bug #1838136 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.2
Fix Released
Low
Unassigned
3.3
Fix Released
Low
Unassigned

Bug Description

Angular creates a file called .editorconfig by default, which sets up 2-space indentation throughout the Angular app. That setting is then read by the likes of GitHub and this popular VS Code extension: https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig

However, our best practices have 4-space indentation in ts and css files in the Angular app: https://wiki.evergreen-ils.org/doku.php?id=dev:angular_dev_best_practices

We should change .editorconfig so that IDEs automatically help folks adhere to these best practices.

Branch forthcoming.

Revision history for this message
Jane Sandberg (sandbergja) wrote :
tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Makes sense to me. Sign-off pushed to user/gmcharlt/lp1838136_fix_editorconfig.

tags: added: signedoff
Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, and rel_3_2. Thanks, Jane!

Changed in evergreen:
status: Confirmed → Fix Committed
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.4-beta1
no longer affects: evergreen/3.4
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.