Bonds should accept ethtool options

Bug #1837764 reported by Dan Sneddon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-net-config
In Progress
High
Dan Sneddon

Bug Description

os-net-config accepts ethtool options for interfaces, but not bonds. Under ordinary circumstances, it is sufficient to set the ethtool options on the member interfaces. However, if a bond has ethtool settings which contradict the interface settings, the bond settings may override the interface settings. For instance, if a bond had been manually configured to turn off offloading, then the bond will not offload even if the member interfaces are configured to enable offloading.

In order to be able to ensure that a bond has the proper ethtool settings, we need to add ethtool options to the bond object.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/672569

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/672570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-net-config (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/672572

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/stein)

Reviewed: https://review.opendev.org/672569
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=3fc167f17d67235023feb87187ed88f75677b744
Submitter: Zuul
Branch: stable/stein

commit 3fc167f17d67235023feb87187ed88f75677b744
Author: Keigo Noha <email address hidden>
Date: Thu Jul 18 15:15:30 2019 +0900

    Add ETHTOOL_OPTS support for LinuxBond class

    LinuxBonding accepts ETHTOOL_OPTS.
    This commit adds ETHTOOL_OPTS support for LinuxBond class.

    Closes-bug: 1837764
    Change-Id: I85fc4a617532bf8ebd19f54dc87f49b5a2e3810f
    (cherry picked from commit 35fc5d66ab5e88d5f28d6b6c47b5c4440ca8d089)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/rocky)

Reviewed: https://review.opendev.org/672570
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=012f636811f608bde4ca8ce290c46122b983e8de
Submitter: Zuul
Branch: stable/rocky

commit 012f636811f608bde4ca8ce290c46122b983e8de
Author: Keigo Noha <email address hidden>
Date: Thu Jul 18 15:15:30 2019 +0900

    Add ETHTOOL_OPTS support for LinuxBond class

    LinuxBonding accepts ETHTOOL_OPTS.
    This commit adds ETHTOOL_OPTS support for LinuxBond class.

    Closes-bug: 1837764
    Change-Id: I85fc4a617532bf8ebd19f54dc87f49b5a2e3810f
    (cherry picked from commit 35fc5d66ab5e88d5f28d6b6c47b5c4440ca8d089)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-net-config (stable/queens)

Reviewed: https://review.opendev.org/672572
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=2aa173d975899e7a40b8a4934483ad3dcc44093b
Submitter: Zuul
Branch: stable/queens

commit 2aa173d975899e7a40b8a4934483ad3dcc44093b
Author: Keigo Noha <email address hidden>
Date: Thu Jul 18 15:15:30 2019 +0900

    Add ETHTOOL_OPTS support for LinuxBond class

    LinuxBonding accepts ETHTOOL_OPTS.
    This commit adds ETHTOOL_OPTS support for LinuxBond class.

    Closes-bug: 1837764
    Change-Id: I85fc4a617532bf8ebd19f54dc87f49b5a2e3810f
    (cherry picked from commit 35fc5d66ab5e88d5f28d6b6c47b5c4440ca8d089)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 10.4.1

This issue was fixed in the openstack/os-net-config 10.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 9.4.1

This issue was fixed in the openstack/os-net-config 9.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-net-config 8.5.1

This issue was fixed in the openstack/os-net-config 8.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.