Stein upgrade fails on compute node - editing libvirt-guests config on the host

[Jiří Stránský]

`upgrade run` step for compute node fails with:

TASK [Debug output for task: Run puppet host configuration for step 4] *********
Friday 19 July 2019 14:01:17 +0000 (0:00:05.583) 0:06:20.818 ***********
fatal: [compute-0]: FAILED! => {

... snip ...

        "<13>Jul 19 14:01:16 puppet-user: Error: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_BOOT]: Could not evaluate: No such file or directory @ rb_sysopen - /etc/sy$
config/libvirt-guests",
        "<13>Jul 19 14:01:16 puppet-user: Error: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_SHUTDOWN]: Could not evaluate: No such file or directory @ rb_sysopen - /et$
/sysconfig/libvirt-guests",
        "<13>Jul 19 14:01:16 puppet-user: Error: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests SHUTDOWN_TIMEOUT]: Could not evaluate: No such file or directory @ rb_sysopen $
 /etc/sysconfig/libvirt-guests",

Installing libvirt-client on the host is a successful workaround, but it's been suggested it may not be the proper solution (https://review.opendev.org/#/c/669122/).

[Alex Schultz (alex-schultz)]

We can add the libvirt-client install, but it needs to be accounted for in puppet-nova and not in tripleo-code

[Martin Schuppert (mschuppert)]

I think the puppet module does the right thing, but the norpm provider
prevents the package from being installed:

Jul 29 10:38:16 compute-0 puppet-user[29414]: [norpm] Attempting to install libvirt-client but it will not be installed

We have libvirt-client as a dependency of libvirt [1] in the overcloud image. So this is only in
case of in place upgrade.

So I think we should add the package in an upgrade task like Jiri in case of in place upgrade.

@Alex, what you think?

[1] https://github.com/openstack/tripleo-puppet-elements/blob/master/elements/overcloud-compute/pkg-map#L5

[Martin Schuppert (mschuppert)]

In general shouldn't we make sure that the upgrade process installs
all packages we have defined as baseline in tripleo-puppet-elements?

[Martin Schuppert (mschuppert)]

Ok, so the issue seems that EnablePackageInstall: True is not being passed.
If I remove the libvirt-client package from a compute and deploy using
'EnablePackageInstall: True' the RPM gets correct installed but the puppet-nova class.

Jul 31 11:19:56 compute-0 os-collect-config: "Debug: Executing: '/usr/bin/rpm -q libvirt-client --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n'",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: Executing: '/usr/bin/rpm -q libvirt-client --nosignature --nodigest --qf %{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n --whatprovides'",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: Package[nova-libvirt-guests](provider=yum): Ensuring => present",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: Executing: '/usr/bin/yum -d 0 -e 0 -y install libvirt-client'",
Jul 31 11:19:56 compute-0 os-collect-config: "Notice: /Stage[main]/Nova::Compute::Libvirt_guests/Nova::Generic_service[libvirt-guests]/Package[nova-libvirt-guests]/ensure: created",
Jul 31 11:19:56 compute-0 os-collect-config: "Info: /Stage[main]/Nova::Compute::Libvirt_guests/Nova::Generic_service[libvirt-guests]/Package[nova-libvirt-guests]: Scheduling refresh of Anchor[nova::install::end]",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: /Stage[main]/Nova::Compute::Libvirt_guests/Nova::Generic_service[libvirt-guests]/Package[nova-libvirt-guests]: The container Nova::Generic_service[libvirt-guests] will propagate my refresh event",
Jul 31 11:19:56 compute-0 os-collect-config: "Notice: /Stage[main]/Nova::Deps/Anchor[nova::install::end]: Triggered 'refresh' from 1 events",
Jul 31 11:19:56 compute-0 os-collect-config: "Info: /Stage[main]/Nova::Deps/Anchor[nova::install::end]: Scheduling refresh of Anchor[nova::service::begin]",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: /Stage[main]/Nova::Deps/Anchor[nova::install::end]: The container Class[Nova::Deps] will propagate my refresh event",
Jul 31 11:19:56 compute-0 os-collect-config: "Notice: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_BOOT]/ensure: created",
Jul 31 11:19:56 compute-0 os-collect-config: "Info: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_BOOT]: Scheduling refresh of Service[nova-libvirt-guests]",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_BOOT]: The container Class[Nova::Compute::Libvirt_guests] will propagate my refresh event",
Jul 31 11:19:56 compute-0 os-collect-config: "Notice: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_SHUTDOWN]/ensure: created",
Jul 31 11:19:56 compute-0 os-collect-config: "Info: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_SHUTDOWN]: Scheduling refresh of Service[nova-libvirt-guests]",
Jul 31 11:19:56 compute-0 os-collect-config: "Debug: /Stage[main]/Nova::Compute::Libvirt_guests/File_line[/etc/sysconfig/libvirt-guests ON_SHUTDOWN]: The container Class[Nova::Compute::Libvirt_guests] will propagate my refresh event",
Jul 31 11:1...

[Jiří Stránský (jistr)]

Fixed in https://review.opendev.org/#/c/679003/