tripleo

haproxy redis stanza needs tcp-check connect port 6379 line

Bug #1837086 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Michele Baldessari
tripleo train-2

Bug Description

When https://bugzilla.redhat.com/show_bug.cgi?id=1677420 will be merged in haproxy (via haproxy-1.5.18-9.el7.x86_64) our redis backend will stop working because the fix around tcp-check is now more correct and according to the haproxy doc a tcp-check sections *must* start with tcp-check connect first. From http://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4-tcp-check%20connect :
"""
When there are no TCP port configured on the server line neither server port
directive, then the 'tcp-check connect port <port>' must be the first step
of the sequence.
"""

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.opendev.org/671526

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/671985

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/671986

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/671987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/671526
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e1cc8d0b0b1e1e55a80774421712eb4126dbe9b0
Submitter: Zuul
Branch: master

commit e1cc8d0b0b1e1e55a80774421712eb4126dbe9b0
Author: Michele Baldessari <email address hidden>
Date: Thu Jul 18 19:09:17 2019 +0200

    Add tcp-check connect port line to haproxy redis stanza

    When https://bugzilla.redhat.com/show_bug.cgi?id=1677420 will be merged
    in haproxy (via haproxy-1.5.18-9.el7.x86_64) our redis backend will stop
    working because the fix around tcp-check is now more correct and
    according to the haproxy doc a tcp-check sections *must* start with
    tcp-check connect first. From
    http://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4-tcp-check%20connect
    :
    """
    When there are no TCP port configured on the server line neither server port
    directive, then the 'tcp-check connect port <port>' must be the first step
    of the sequence.
    """

    Change-Id: I261eb30b52a3baee3b0e6d47e8f32f3c579930bf
    Co-Authored-By: Luca Miccini <email address hidden>
    Closes-Bug: #1837086

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/stein)

Reviewed: https://review.opendev.org/671985
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c71f507b64b2197d76308409cf0d7f406ff32eff
Submitter: Zuul
Branch: stable/stein

commit c71f507b64b2197d76308409cf0d7f406ff32eff
Author: Michele Baldessari <email address hidden>
Date: Thu Jul 18 19:09:17 2019 +0200

    Add tcp-check connect port line to haproxy redis stanza

    When https://bugzilla.redhat.com/show_bug.cgi?id=1677420 will be merged
    in haproxy (via haproxy-1.5.18-9.el7.x86_64) our redis backend will stop
    working because the fix around tcp-check is now more correct and
    according to the haproxy doc a tcp-check sections *must* start with
    tcp-check connect first. From
    http://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4-tcp-check%20connect
    :
    """
    When there are no TCP port configured on the server line neither server port
    directive, then the 'tcp-check connect port <port>' must be the first step
    of the sequence.
    """

    Change-Id: I261eb30b52a3baee3b0e6d47e8f32f3c579930bf
    Co-Authored-By: Luca Miccini <email address hidden>
    Closes-Bug: #1837086

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/rocky)

Reviewed: https://review.opendev.org/671986
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=9ca9f3706483f3802cd1498cd0879263269c059d
Submitter: Zuul
Branch: stable/rocky

commit 9ca9f3706483f3802cd1498cd0879263269c059d
Author: Michele Baldessari <email address hidden>
Date: Thu Jul 18 19:09:17 2019 +0200

    Add tcp-check connect port line to haproxy redis stanza

    When https://bugzilla.redhat.com/show_bug.cgi?id=1677420 will be merged
    in haproxy (via haproxy-1.5.18-9.el7.x86_64) our redis backend will stop
    working because the fix around tcp-check is now more correct and
    according to the haproxy doc a tcp-check sections *must* start with
    tcp-check connect first. From
    http://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4-tcp-check%20connect
    :
    """
    When there are no TCP port configured on the server line neither server port
    directive, then the 'tcp-check connect port <port>' must be the first step
    of the sequence.
    """

    Change-Id: I261eb30b52a3baee3b0e6d47e8f32f3c579930bf
    Co-Authored-By: Luca Miccini <email address hidden>
    Closes-Bug: #1837086

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.opendev.org/671987
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=ab1ae917df5dc13566f98e82c9a5b6c3ed2b54a5
Submitter: Zuul
Branch: stable/queens

commit ab1ae917df5dc13566f98e82c9a5b6c3ed2b54a5
Author: Michele Baldessari <email address hidden>
Date: Thu Jul 18 19:09:17 2019 +0200

    Add tcp-check connect port line to haproxy redis stanza

    When https://bugzilla.redhat.com/show_bug.cgi?id=1677420 will be merged
    in haproxy (via haproxy-1.5.18-9.el7.x86_64) our redis backend will stop
    working because the fix around tcp-check is now more correct and
    according to the haproxy doc a tcp-check sections *must* start with
    tcp-check connect first. From
    http://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4-tcp-check%20connect
    :
    """
    When there are no TCP port configured on the server line neither server port
    directive, then the 'tcp-check connect port <port>' must be the first step
    of the sequence.
    """

    Change-Id: I261eb30b52a3baee3b0e6d47e8f32f3c579930bf
    Co-Authored-By: Luca Miccini <email address hidden>
    Closes-Bug: #1837086

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 11.1.0

This issue was fixed in the openstack/puppet-tripleo 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 10.5.1

This issue was fixed in the openstack/puppet-tripleo 10.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 9.5.1

This issue was fixed in the openstack/puppet-tripleo 9.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 8.5.1

This issue was fixed in the openstack/puppet-tripleo 8.5.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.