[promotion][check][master] standalone upgrade job failing with: the role 'tripleo-docker-rm' was not found in role path

[yatin]

Standalone upgrade job is failing in both check and promotion pipeline with below error:-

the role 'tripleo-docker-rm' was not found in /home/zuul/undercloud-ansible-Ze5n8V/roles:/home/zuul/undercloud-ansible-Ze5n8V/roles:/root/.ansible/roles:/usr/share/ansible/tripleo-roles:/usr/share/ansible/roles:/etc/ansible/roles:/usr/share/openstack-tripleo-validations/roles:/home/zuul/undercloud-ansible-Ze5n8V:/home/zuul/undercloud-ansible-Ze5n8V\n\nThe error appears to be in '/home/zuul/undercloud-ansible-Ze5n8V/Standalone/post_upgrade_tasks.yaml': line 2, column 11, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- import_role:\n name: tripleo-docker-rm\n ^ here\n"

Logs:-
http://logs.openstack.org/03/667103/6/check/tripleo-ci-centos-7-standalone-upgrade/2cbffe4/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2019-07-01_15_39_36
https://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-standalone-upgrade-master/fcd8e8a/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2019-07-11_02_11_22

Happening after tripleo-docker-rm role is removed from tripleo-common:- https://review.opendev.org/#/c/667103/

In tripleo-ansible the role exists as a symlink to tripleo-container-rm, but when installed, the tripleo-docker-rm role is not installed at usr/share/ansible/tripleo-roles.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/670272
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=add4969e6b2213310a3c3288f1395aa6fbae75bf
Submitter: Zuul
Branch: master

commit add4969e6b2213310a3c3288f1395aa6fbae75bf
Author: Sagi Shnaidman <email address hidden>
Date: Thu Jul 11 13:36:16 2019 +0300

    Fix setup.py for symlinked tripleo-docker-rm

    setup.py doens't handle symlinks, so copy files explicitly
    Closes-Bug: #1836145
    Change-Id: I02a0e95519ac33ca15b36aaef3f40f61ad10217b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/670319

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/670336

[wes hayutin (weshayutin)]

tripleo-docker-rm is found.. so the original bug is fixed. I suspect we need a new bug for

2019-07-11 20:32:43 | 2019-07-11 20:32:43.999 81858 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] TASK [tripleo-docker-rm : Stop container] **************************************
2019-07-11 20:32:45 | 2019-07-11 20:32:45.180 81858 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] fatal: [standalone]: FAILED! => {"changed": true, "cmd": ["podman", "container", "kill", "cinder_api"], "delta": "0:00:01.065814", "end": "2019-07-11 20:32:45.168378", "msg": "non-zero return code", "rc": 125, "start": "2019-07-11 20:32:44.102564", "stderr": "Error: can only kill running containers. 234510311da714ea7805171ebf3836c76f76bd53faf4950e35eaecaca716d02a is in state stopped: container state improper", "stderr_lines": ["Error: can only kill running containers. 234510311da714ea7805171ebf3836c76f76bd53faf4950e35eaecaca716d02a is in state stopped: container state improper"], "stdout": "", "stdout_lines": []}

http://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-standalone-upgrade-master/fba61ab/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz

[wes hayutin (weshayutin)]

I see both
two more patches in flight
https://review.opendev.org/#/c/670319/
https://review.opendev.org/#/c/670336/

address stopping containers that are not running :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/670319
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=78951712ad5f35372b7298de067a9aa2a878f5d4
Submitter: Zuul
Branch: master

commit 78951712ad5f35372b7298de067a9aa2a878f5d4
Author: Kevin Carter <email address hidden>
Date: Thu Jul 11 09:41:34 2019 -0500

    Force removal of stopped or running containers

    Use --force to remove containers, no matter what is its
    current state.

    Closes-Bug: #1836145
    Change-Id: I20bdb523d918adb33c5f72512d960d3709bd4895
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/670336
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=1f235eb51eb9ae764b01c31f1c1566f723d0fc1c
Submitter: Zuul
Branch: master

commit 1f235eb51eb9ae764b01c31f1c1566f723d0fc1c
Author: Kevin Carter <email address hidden>
Date: Thu Jul 11 10:29:44 2019 -0500

    Add molecule test for stopped container scenario

    This change adds a test to the tripleo-container-rm role to ensure
    we're able to remove podman containers that are in a stopped state.

    Closes-Bug: #1836145
    Change-Id: I6bbdb3d191d5bbe3cd976a5d028685d7dcbc8eab
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.2.0 release.