Esc doesn't exit highlight net

[Seth Hillbrand]

Related reports:

lp:1741330
lp:1800301

This appears to have been re-introduced. Use hotkey '`' to highlight a net. Pressing escape does not exit the highlight. You have to select the highlight again away from a selectable net.

Application: Pcbnew
Version: (5.1.0-1213-g44734dc05-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

As an addendum, using the hotkey appears to put you into the highlight tool where clicking again will highlight a new net rather than staying in the previous tool.

[Jeff Young (jeyjey)]

This ran afoul of the "all tools handle their own cancel operations". While that cleaned up a lot of other side-effects, it does make it a bit harder for tools to gracefully handle stuff like this.

It's a bit of a hack but I gave the SELECTION_TOOL a "skip next net unhighlight" flag that the Net Highlight sets when cancelling itself.

[Seth Hillbrand (sethh)]

I think I'd prefer the stacking:

1) Choose tool
2) Highlight net using hotkey
3) Back in tool with net highlighted

Then pressing escape does, in order
First escape press: Cancel current action in current tool (if one is started) otherwise:
Second escape press: Cancel highlighting if anything highlighted, otherwise:
Third escape press: Exit tool back to select tool

[Jeff Young (jeyjey)]

Ooops; stuck this comment in the wrong bug report:

I played with that [which referred to my comment #2 at the time] a bit, and it doesn't feel right. If I highlight a net, go to the track tool and then hit <esc> I expect to cancel the track tool but it also cancels the net highlighting. I think we only want to clear the net highlighting when there's nothing else left to clear.

That's all about the Highlight Net /tool/ though, which is somewhat orthogonal to Seth's comment above (which is about the hotkeys).

[Jeff Young (jeyjey)]

I also move the Hotkey from activating the tool to doing a one-shot immediate action. This addresses Seth's comment #3.

[KiCad Janitor (kicad-janitor)]

Fixed in revision a11f3a0b8015e807af6b9d78ca67f788d2440153
https://git.launchpad.net/kicad/patch/?id=a11f3a0b8015e807af6b9d78ca67f788d2440153