Dry run fails with logging forwarding tasks

[Emilien Macchi]

Reported in Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1726927

Description of problem:
Running config-download playbooks in check mode is feature that supported from Rocky, currently it fails on different issues which is a regression

How reproducible:
ansible-playbook --check --become -i /home/stack/inventory.yaml /home/stack/config-download/deploy_steps_playbook.yaml

Actual results:
TASK [Forward logging to swift.log file] ***************************************
fatal: [controller-0]: FAILED! => {"msg": "The conditional check 'rsyslog_config.rc == 0' failed. The error was: error while evaluating conditional (rsyslog_config.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/home/stack/config-download/Controller/host_prep_tasks.yaml': line 888, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - copy:\n ^ here\n"}

Expected results:
Pass

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/669179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669179
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=58bf8a207b853dffe70da3ad93b3b90cddd43087
Submitter: Zuul
Branch: master

commit 58bf8a207b853dffe70da3ad93b3b90cddd43087
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 4 09:40:14 2019 -0400

    swift: ensure we get rsyslog state "--check" mode

    Ensure that the logging forwarding tasks do not fail in ansible check
    mode, and we make sure the rsyslog_config is actually defined.

    Change-Id: Ifaf692643f21f2ae30557b251ae58a9b32fbb143
    Closes-Bug: #1835415

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/669665

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669665
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e022668a0caa7aaf183a8e22dc2933f334e8fe5f
Submitter: Zuul
Branch: stable/stein

commit e022668a0caa7aaf183a8e22dc2933f334e8fe5f
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 4 09:40:14 2019 -0400

    swift: ensure we get rsyslog state "--check" mode

    Ensure that the logging forwarding tasks do not fail in ansible check
    mode, and we make sure the rsyslog_config is actually defined.

    Change-Id: Ifaf692643f21f2ae30557b251ae58a9b32fbb143
    Closes-Bug: #1835415
    (cherry picked from commit 58bf8a207b853dffe70da3ad93b3b90cddd43087)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.1 release.