pcbnew: "Delete" does not work when selection is ambiguous

[Giorgio Croci Candiani]

When routing track tool ("x" key) is active, but no track is currently being drawn, pressing "del" while pointing a track appears not to work.

It is easy to verify that this happens when the selection of the underlying elements is not unambiguous: in fact, doing the same when the tool is not active, the selection menu for the target element appears.

I think it is straightforward that the same menu should appear even when the tool is active.

I didn't notice if this also happens with other tools; however I can say that the behaviour is there from quite a few releases, not new to this one.

Application: Pcbnew
Version: (5.1.0-1171-g743c65012), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

This can cause crashes when the menu state gets tangled up in the tool state.

[KiCad Janitor (kicad-janitor)]

Fixed in revision c60118b6a462f86e005c715df62acd858e3dbeb4
https://git.launchpad.net/kicad/patch/?id=c60118b6a462f86e005c715df62acd858e3dbeb4