Manager can't see peer block when published

Bug #1835321 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
18.10
Fix Released
High
Unassigned
19.04
Fix Released
High
Unassigned
19.10
Fix Released
High
Cecilia Vela Gurovic

Bug Description

Once the peer has published the assessment, it should be visible to anyone who has access to the page, including the manager

Changed in mahara:
importance: Undecided → High
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10142

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 7a2d6ce63df42f5b330927f5d7176df64487fff7
Environment tested: Master
Browser tested: Chrome
Theme used: Raw | Default raw | Ocean | Modern | Primary school

PRECONDITIONS:
------------------------
1) Mahara User exists (User13) and has a portfolio page with the following
 a) Content blocks on the page
 b) Peer assessment block on the page
2) User has shared the page with the following users with the following roles
 a) User14 - peer role
 b) User15 - manager role
 c) User16 - peer & manager role

TEST STEPS:
------------------------
1) Log in as User14 (peer)
2) Browse to User13's portfolio page that is ready for peer review
3) Verify that user can see The peer assessment block and the link "+ Add peer assessment" ✔
4) Click the link
5) Verify that user can see Instructions (NOTE: this field is hidden until the chevron icon is clicked) ✔
6) Make an assessment comment and save draft
7) Log out and log back in as User15 (manager)
8) Browse to User13's portfolio page that is ready for peer review
9) Verify that User cannot see any assessments in the Peer review block ✔
10) Log out and log back in as User16 (peer & manager)
11) Browse to User13's portfolio page that is ready for peer review
12) Verify that User cannot see any assessments in the Peer review block ✔
13) Log out and log back in as User14 (peer)
14) Publish the "draft" assessment
15) Log out and log back in as User15 (manager)
16) Verify that User can see the published assessment in the Peer review block ✔
19) Log out and log back in as User16 (peer & manager)
20) Verify that User can see the published assessment in the Peer review block ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10142
Committed: https://git.mahara.org/mahara/mahara/commit/7a2d6ce63df42f5b330927f5d7176df64487fff7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7a2d6ce63df42f5b330927f5d7176df64487fff7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jul 4 11:26:29 2019 +1200

Bug 1835321: Manager can't see peer block when published

WR#315075

Once the asessment is published by the author,
it'is supposed to be visible to everybody that
has access to the view

behatnotneeded

Change-Id: I116b665945a3d45fa2a14bb7654e55f561428368

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10168

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10168
Committed: https://git.mahara.org/mahara/mahara/commit/6de718b7c55beef8d473b3c55b11114bbc5ac54e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 6de718b7c55beef8d473b3c55b11114bbc5ac54e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jul 4 11:26:29 2019 +1200

Bug 1835321: Manager can't see peer block when published

WR#315075

Once the asessment is published by the author,
it'is supposed to be visible to everybody that
has access to the view

behatnotneeded

Change-Id: I116b665945a3d45fa2a14bb7654e55f561428368
(cherry picked from commit 7a2d6ce63df42f5b330927f5d7176df64487fff7)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10169

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10169
Committed: https://git.mahara.org/mahara/mahara/commit/12235f114280753e0471f31d8d45298058e4d6b7
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 12235f114280753e0471f31d8d45298058e4d6b7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jul 4 11:26:29 2019 +1200

Bug 1835321: Manager can't see peer block when published

WR#315075

Once the asessment is published by the author,
it'is supposed to be visible to everybody that
has access to the view

behatnotneeded

Change-Id: I116b665945a3d45fa2a14bb7654e55f561428368
(cherry picked from commit 7a2d6ce63df42f5b330927f5d7176df64487fff7)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10202

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10206

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10207

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10207
Committed: https://git.mahara.org/mahara/mahara/commit/9cefb8a67ff8d499de7a02980d0e137e8aa3e086
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 9cefb8a67ff8d499de7a02980d0e137e8aa3e086
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 22 12:12:59 2019 +1200

Bug 1835321: behat test- published assessment is visible

for all user that can access the view

Change-Id: If29fe56b993f27f69601e3536b6fd2baea47f363

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10202
Committed: https://git.mahara.org/mahara/mahara/commit/e59a6cec88c7c927c53a28683d134e7dd7eb0e9e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit e59a6cec88c7c927c53a28683d134e7dd7eb0e9e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 22 12:12:59 2019 +1200

Bug 1835321: behat test- published assessment is visible

for all user that can access the view

Change-Id: If29fe56b993f27f69601e3536b6fd2baea47f363

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10206
Committed: https://git.mahara.org/mahara/mahara/commit/0b7bd0f82e3931bd842b12be87a15f528ef343e1
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 0b7bd0f82e3931bd842b12be87a15f528ef343e1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 22 12:12:59 2019 +1200

Bug 1835321: behat test- published assessment is visible

for all user that can access the view

Change-Id: If29fe56b993f27f69601e3536b6fd2baea47f363

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.