Cancel button locked out with invalid footprint name

[Ian McInerney]

In the footprint properties dialog of the footprint editor, when an invalid footprint name (such as "FD 'tab' fd") is entered, the cancel button can no longer be used. It appears that the validator is blocking the cancel action, so the only way to exit the window and ignore changes is to hit ESC. Ideally the cancel button should work even when invalid text is in the field, since it should revert to the previously valid text.

Application: Pcbnew
Version: (5.1.2-177-gce329e13f), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 brotli/1.0.7 libidn2/2.1.1 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.8.7/openssl/zlib nghttp2/1.37.0
Platform: Linux 5.1.15-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I can't reproduce this on OSX, but I just changes some very related stuff (for https://bugs.launchpad.net/kicad/+bug/1834966), so it's possible I fixed it.

[Ian McInerney (imcinerney)]

@Jeff, your fix for the other bug changed the behavior slightly: now it only locks out the button on the first try, so the second try is able to close the window. I have captured the behavior in the attached screencast.

[Jeff Young (jeyjey)]

Ahh, yes. I've had this fight with wxWidgets/GTK before (with the UNIT_BINDER's KillFocus event). It's unwinable.

I'm going to remove the KillFocus validation. We'll just have to rely on the OK validations.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1c30f3d9a97d2058ec4c88ee75ffc3b8d85a7afa
https://git.launchpad.net/kicad/patch/?id=1c30f3d9a97d2058ec4c88ee75ffc3b8d85a7afa