Current default fails to build

[tduell]

Attempting to build the current Enblend default source in Fedora 30, using rpmbuild.
Build fails with the following message...

In file included from /home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.cc:188:
/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.h: In function 'void enblend::enfuseMain(const FileNameList&, const std::__cxx11::list<vigra::ImageImportInfo*>&, vigra::ImageExportInfo&, vigra::Rect2D&)':
/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.h:1269:27: error: 'Error' in namespace 'Exiv2' does not name a type
 1269 | catch (Exiv2::Error& e) {
      | ^~~~~
/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.h:1273:46: error: 'e' was not declared in this scope
 1273 | command << ": note: " << e.what() << "\n";
      | ^
/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.h:1654:27: error: 'Error' in namespace 'Exiv2' does not name a type
 1654 | catch (Exiv2::Error& e) {
      | ^~~~~
/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source/src/enfuse.h:1658:46: error: 'e' was not declared in this scope
 1658 | command << ": note: " << e.what() << "\n";
      | ^
make[2]: *** [src/CMakeFiles/enfuse.dir/build.make:79: src/CMakeFiles/enfuse.dir/enfuse.cc.o] Error 1
make[2]: Leaving directory '/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source'
make[1]: *** [CMakeFiles/Makefile2:215: src/CMakeFiles/enfuse.dir/all] Error 2
make[1]: Leaving directory '/home/terry/rpmbuild/BUILD/enblend-4.3.0-1519hg-Source'
make: *** [Makefile:155: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.zxxB72 (%build)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.zxxB72 (%build)

Hope this helps.

Cheers,
Terry

[Bruno Postle (brunopostle)]

Hi Terry, this seems similar to the exiv2 bug you found in Hugin, i.e: #include <exiv2/image.hpp> should now be #include <exiv2/exiv2.hpp>

[tduell (tduell-iinet)]

Hello Bruno,
Thanks for that thought.
If I get time I'll have a look, but Thomas probably knows his way around the code much better than I do and may beat me to trying this fix.

Cheers,
Terry

[tduell (tduell-iinet)]

OK, I've tried that fix and it does now build, but haven't used the build in anger.
Doc build problems did occur...seems to be a regular issue with Fedora, so had to switch off building of any docs.
I haven't looked at why the docs are an issue, beyond my ken.
I have attached a patch for others to test further.

Cheers,
Terry

[Bruno Postle (brunopostle)]

I think the docs problem is a fedora issue. I've given up building the enblend docs as they break more than anything else

[tduell (tduell-iinet)]

Hello Bruno,
I probably should push my fix to the repo, if you are happy with it.
I don't think I have ever done that previously for Enblend, I can't find any reference in my notes to what the push command to enblend looks like, or find any reference anywhere.
I assume I have push privilege ??
If so can you provide the relevant push command ?
As an aside, are you aware if Dr Chris Spiel still maintaining/developing Enblend?

Cheers,
Terry

[Bruno Postle (brunopostle)]

Hi Terry, I'm not sure if you have mercurial commit access. Use these commands to commit your changes to your local repository, then try to push any changes to the sourceforge repository:

  hg commit
  hg push

I have no idea if Christoph has abandoned or paused development. He has only been quiet for a year or so, which doesn't seem like a _very_ long time.

[tduell (tduell-iinet)]

Thanks for that.
It seems to have worked.

Cheers,
Terry

[tmodes (tmodes)]

I've seen this ticket only now.
I committed the Terry's patch (with an update of the VERSION file) to the repository.