Ctrl-click selection inconsistency

[Seth Hillbrand]

In libedit and eeschema, Ctrl-Click will select a single element while Ctrl-Drag will deselect elements. In pcbnew and modedit, Ctrl-Click does nothing and Ctrl-Drag deselects

Shift-Click and shift-drag both select elements.

Our UX guidelines state that Ctrl-Click should be a selection toggle and Shift-Click should be a selection extend. I think Ctrl-Drag as a deselect makes sense (no guidelines on this)

Application: LibEdit
Version: (5.1.0-1152-gc9ccd8a64), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

Ctrl-click highlights nets in Eeschem and Pcbnew, no? (It's cmd-click on Mac, but that maps to Ctrl-click elsewhere, doesn't it?)

[Seth Hillbrand (sethh)]

@Jeff- Yes, I think that is correct. But it goes against our stated guidelines[1] and the MacOS guidelines[2] as well as how selection works in Windows (although I can't find guidelines here).

Because we are standardizing the selection mechanism throughout KiCad, I think it's worth addressing the inconsistency.

Since highlight already requires a key-press, I wonder if we could simply limit it to the existing hotkey (~) and keep the gesture reserved in selection mode for the selection operations.

Thoughts?

[1] https://developer.gnome.org/hig/stable/pointer-and-touch-input.html.en#mouse-and-keyboard-equivalents
[2] https://support.apple.com/guide/mac-help/select-items-mchlp1378/mac

[Wayne Stambaugh (stambaughw)]

We should definitely keep select consistent between editor. I cannot think of a good reason why we would want to make them inconsistent.

[Wayne Stambaugh (stambaughw)]

Unless we are going to the AutoCAD selection model. In this case, no ctrl/cmd key is required for select actions and the shift key is required for deselect actions.

[Jeff Young (jeyjey)]

I think ctrl-drag and ctrl-click need to be the same (exclusive-or).

Most Mac apps don't implement subtract at all, just add (shift) and exclusive-or (ctrl). However, just in case someone is really attached to it I'll map subtract to shift+ctrl.

.

(Note that I'm using Kicad shorthand: all those ctrls are actually cmds on Mac.)