Dry-run verification fails on task Stop iscsi.service

[Cédric Jeanneret]

Hello,

Running config-download playbook with --check (dry-run mode) fails:

TASK [Stop iscsi.service] ******************************************************
fatal: [controller-0]: FAILED! => {"msg": "The conditional check 'iscsi_service_enabled_result.rc == 0' failed. The error was: error while evaluating conditional (iscsi_service_enabled_result.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/home/stack/config-download/Controller/host_prep_tasks.yaml': line 592, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n register: iscsi_service_enabled_result\n- name: Stop iscsi.service\n ^ here\n"}

This is the same kind of issue as haproxy+rsyslog configuration.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/667783

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667783
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2d4430bd7188a7ae49a8cdb15b1dd546b46c7de5
Submitter: Zuul
Branch: master

commit 2d4430bd7188a7ae49a8cdb15b1dd546b46c7de5
Author: Cédric Jeanneret <email address hidden>
Date: Thu Jun 27 07:21:11 2019 +0200

    Avoid checking rc if we're in dry-run mode

    Currently running `ansible --check' against generated playbook fails
    because the "exec" won't be done, hence the registered resource won't
    get the "rc" entry.

    Change-Id: Ic8001d4fd8c489f10c565d05ae82060fa3fb6ce8
    Closes-Bug: #1834409

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/668023

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/668023
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=93ead16ca213db8f3ef18a40c55437e324c50740
Submitter: Zuul
Branch: stable/stein

commit 93ead16ca213db8f3ef18a40c55437e324c50740
Author: Cédric Jeanneret <email address hidden>
Date: Thu Jun 27 07:21:11 2019 +0200

    Avoid checking rc if we're in dry-run mode

    Currently running `ansible --check' against generated playbook fails
    because the "exec" won't be done, hence the registered resource won't
    get the "rc" entry.

    Change-Id: Ic8001d4fd8c489f10c565d05ae82060fa3fb6ce8
    Closes-Bug: #1834409
    (cherry picked from commit 2d4430bd7188a7ae49a8cdb15b1dd546b46c7de5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.