[promotion][master][tripleo-ansible] jobs failing with 'tripleo_container_image' is undefined

[yatin]

Promotion jobs are failing with below error:-

The task includes an option with an undefined variable. The error was: 'tripleo_container_image' is undefined

Example logs:-
https://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-scenario004-standalone-master/56aaf81/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2019-06-25_19_48_29
https://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-master/380ec93/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2019-06-25_20_15_57

tripleo-ansible is installed as a dependency of tripleo-heat-templates. tripleo-ansible is under major refactoring and importing roles to it and since it's deployed roles are under ansible roles_path they are picked up and causing issues. Also there is no tripleo deployment jobs running with tripleo-ansible changes yet and hence the issue is detected in promotion jobs, there is a plan to add those in near future.

[Kevin Carter (kevin-carter)]

First pr to help resolve - https://review.opendev.org/#/c/667505

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667505
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=f13fb3f3bc96489529989bf14e08c4fab358ed29
Submitter: Zuul
Branch: master

commit f13fb3f3bc96489529989bf14e08c4fab358ed29
Author: Kevin Carter <email address hidden>
Date: Tue Jun 25 23:20:34 2019 -0500

    Add default for the container_image option

    This creates a default option for `tripleo_container_image` and a failure condition
    when the option is undefined.

    Closes-Bug: #1834283
    Change-Id: Ice80e74b177bfaeedc22f51572e434c01dea18fc
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/667609

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667609
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=8e67d654bf1773091d647b11d36dc996a6d840f7
Submitter: Zuul
Branch: master

commit 8e67d654bf1773091d647b11d36dc996a6d840f7
Author: Kevin Carter <email address hidden>
Date: Wed Jun 26 07:47:17 2019 -0500

    Add legacy variable scenario tests

    This change adds scenario tests for legacy variables across all roles
    which use derived variables from legacy, un-namespaced, options.

    Task: 34742
    Story: 2006049
    Related-Bug: #1834283
    Change-Id: I18b6be271331e59ff66741a958b27d7f044f42ab
    Signed-off-by: Kevin Carter <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.2.0 release.