Kolla affected by [Explicitly set LOCALE_PATHS for Horizon apps] - compilemessages via manage.py run extra compilations

[Radosław Piliszek]

Kolla has been hit by https://opendev.org/openstack/horizon/commit/4e911e2889ebe7f0a577a0323649dceb9cef363c (Explicitly set LOCALE_PATHS for Horizon apps).

We are compiling messages for all projects in a loop using horizon manage.py and the mentioned commit caused them to run needless runs of message compilations - each plugin additionally recompiles the base messages (horizon, openstack_auth, openstack_dashboard).

Run examples:
Pre the affecting horizon commit: http://logs.openstack.org/78/659678/3/check/kolla-build-centos-source/512a3ed/logs/build/horizon.txt.gz
Post the affecting horizon commit: http://logs.openstack.org/15/666015/3/gate/kolla-build-centos-source/423deec/logs/build/horizon.txt.gz

This is an issue for us because centos 7 tends to run these awfully slow and the extra burden is too much to stay in CI time bounds.
My current workaround involves using django-admin instead: https://review.opendev.org/667204

[Radosław Piliszek (yoctozepto)]

Marcin found out we can do even better by running manage.py from site-packages where it picks up plugins as well. See: https://review.opendev.org/667386

In summary, this bug is about changed behavior but we managed to handle it for kolla.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/667640

[Ivan Kolodyazhny (e0ne)]

Kolla executes compilemessages command for each plugin. It's not a correct way. It should be enough to call it only once

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.opendev.org/667640

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/708414
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=12cd2090b69b2df73ef31d71d40ce9c78958d780
Submitter: Zuul
Branch: master

commit 12cd2090b69b2df73ef31d71d40ce9c78958d780
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Feb 18 15:24:03 2020 +0000

    Revert "Explicitly set LOCALE_PATHS for Horizon apps"

    This reverts commit 4e911e2889ebe7f0a577a0323649dceb9cef363c.

    We don't need this change on the latest master. I'm unable to reproduce
    an original bug without this patch.

    Closes-Bug: #1834167
    Change-Id: Iaffdb64fb0bc58525554ac9d40d2aeadb0876ffd

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 18.1.0 release.