Symbol field validator saying wrong field

[Ian McInerney]

If you enter an invalid character in a new user-defined field, the validator prompt says that the datasheet field cannot contain the character.

Recreate (see attached video):
1) Open pic_programmer
2) Edit fields on J1
3) Create new field (name does not seem to matter)
4) Paste in invalid text (for instance, in notepad do fd 'tab' fd)
5) Hit enter
The validation window that opens says that the datasheet field cannot contain tabs, not the user-defined field.

Application: Eeschema
Version: (5.1.2-151-gc951ca6f4), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.59.0 OpenSSL/1.1.0i zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh/0.8.6/openssl/zlib nghttp2/1.32.1
Platform: Linux 5.0.16-100.fc28.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.59.0
    Compiler: Clang 6.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 15cd13ba6ecb6905c4adee597a112993a3d9537b
https://git.launchpad.net/kicad/patch/?id=15cd13ba6ecb6905c4adee597a112993a3d9537b

[Ian McInerney (imcinerney)]

Jeff, should this be cherry picked into 5.1 or is it not worth fixing in there? (the original report was against 5.1.2)

[Jeff Young (jeyjey)]

@Ian, I don't think it's worth the risk. wxGrid is extremely flaky about destruction order, and there have been other (non-5.1) changes in this area.