Better handling of 'This map requires widelands Version >x'
Bug #1833662 reported by
kaputtnik
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Widelands Website |
Fix Released
|
Undecided
|
Unassigned | ||
widelands |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Just saw that we have already a map which needs a widelands version > 20. See comments in https:/
Currently the distinction regarding the needed widelands version is made from the amount of possible players. I think we need another way to get the needed version. Maybe the packet version can do the trick?
The model wlmaps has to be changed then accordingly.
Related branches
lp:~widelands-dev/widelands/elk_moose
- Klaus Halfmann: Approve (testing)
-
Diff: 455 lines (+102/-30)16 files modifieddata/world/critters/moose/init.lua (+2/-2)
data/world/init.lua (+1/-1)
data/world/map_generation.lua (+6/-6)
src/logic/map.cc (+16/-0)
src/logic/map.h (+8/-0)
src/logic/map_objects/world/critter.cc (+3/-2)
src/logic/map_revision.h (+2/-0)
src/map_io/map_bob_packet.cc (+3/-3)
src/map_io/map_bob_packet.h (+1/-1)
src/map_io/map_saver.cc (+1/-1)
src/map_io/map_version_packet.cc (+12/-5)
src/map_io/map_version_packet.h (+17/-2)
src/map_io/widelands_map_loader.cc (+5/-1)
src/map_io/world_legacy_lookup_table.cc (+23/-5)
src/map_io/world_legacy_lookup_table.h (+1/-1)
src/website/map_info.cc (+1/-0)
lp:~widelands-dev/widelands-website/move_maps_minimap
- kaputtnik (community): Needs Resubmitting
- GunChleoc: Approve
-
Diff: 247 lines (+124/-22)7 files modifiedwlmaps/admin.py (+13/-1)
wlmaps/forms.py (+15/-6)
wlmaps/migrations/0003_auto_20190712_0928.py (+65/-0)
wlmaps/models.py (+16/-1)
wlmaps/templates/wlmaps/index.html (+3/-7)
wlmaps/templates/wlmaps/inlines/version_info.html (+11/-0)
wlmaps/templates/wlmaps/map_detail.html (+1/-7)
description: | updated |
Changed in widelands: | |
status: | Confirmed → Fix Released |
status: | Fix Released → Confirmed |
Changed in widelands-website: | |
status: | Confirmed → Fix Released |
Changed in widelands: | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
This is distinct from the amount of players. We changed the name of a map entity and did not bump any packet numbers.
I have another one of those - let me make a merge request and bump the version number there.