Undercloud update fails when public_host set to IPv6

[Alex Schultz]

2019-06-18 19:01:28,111 INFO: dib-run-parts Tue Jun 18 19:01:28 IDT 2019 Running /usr/libexec/os-refresh-config/configure.d/50-puppet-stack-config
2019-06-18 19:01:28,115 INFO: + set -o pipefail
2019-06-18 19:01:28,116 INFO: + puppet_apply puppet apply --summarize --detailed-exitcodes /etc/puppet/manifests/puppet-stack-config.pp
2019-06-18 19:01:28,116 INFO: + set +e
2019-06-18 19:01:28,116 INFO: + puppet apply --summarize --detailed-exitcodes /etc/puppet/manifests/puppet-stack-config.pp
2019-06-18 19:01:35,420 INFO: Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend
2019-06-18 19:01:35,422 INFO: Error: Evaluation Error: Error while evaluating a Function Call, Lookup of key 'vswitch::ovs::package_ensure' failed: (<unknown>): found unexpected ':' while scanning a plain scalar at line 13 column 34 in (<unknown>): found unexpected ':' while scanning a plain scalar at line 13 column 34 at /etc/puppet/modules/tripleo/manifests/network/os_net_config.pp:22:3 on node undercloud-0.redhat.local
2019-06-18 19:01:35,466 INFO: + rc=1
2019-06-18 19:01:35,466 INFO: + set -e
2019-06-18 19:01:35,466 INFO: + echo 'puppet apply exited with exit code 1'
2019-06-18 19:01:35,467 INFO: puppet apply exited with exit code 1
2019-06-18 19:01:35,467 INFO: + '[' 1 '!=' 2 -a 1 '!=' 0 ']'
2019-06-18 19:01:35,467 INFO: + exit 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/666304

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/666305

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666304
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=e4cc043a1c945dc527f23897df4f06f9fb5ce2b8
Submitter: Zuul
Branch: stable/rocky

commit e4cc043a1c945dc527f23897df4f06f9fb5ce2b8
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 08:22:54 2019 -0600

    Quote controller_public_host_wrapped

    If this is an IPv6 address, it currently will be set to something like
    controller_public_host_wrapped: [2001:db8::2]

    The yaml parser interprets this as a list and tries to part the IPv6
    address as a hash. To avoid this, we need to wrap the value in quotes.

    Change-Id: I9e5d5e6cd6873431a17280a8a8c8ae5af45163c4
    Closes-Bug: #1833429

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666305
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=3d17c6d6856f99e3792633a8bad87876b83d121c
Submitter: Zuul
Branch: stable/queens

commit 3d17c6d6856f99e3792633a8bad87876b83d121c
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 08:22:54 2019 -0600

    Quote controller_public_host_wrapped

    If this is an IPv6 address, it currently will be set to something like
    controller_public_host_wrapped: [2001:db8::2]

    The yaml parser interprets this as a list and tries to part the IPv6
    address as a hash. To avoid this, we need to wrap the value in quotes.

    Change-Id: I9e5d5e6cd6873431a17280a8a8c8ae5af45163c4
    Closes-Bug: #1833429
    (cherry picked from commit e4cc043a1c945dc527f23897df4f06f9fb5ce2b8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 9.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.4.9 release.