Unit tests in networking-bgpvpn are broken

[Slawek Kaplonski]

Unit tests in networking-bgpvpn project are failing 100% times. See http://logs.openstack.org/31/662231/3/check/openstack-tox-py36/adb9abd/testr_results.html.gz for example.

[Slawek Kaplonski (slaweq)]

Looks that the problem is caused by SQLAlchemy 1.3. On 1.2.18 tests are passing.

[Slawek Kaplonski (slaweq)]

Patch proposed https://review.opendev.org/665637

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665637
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=15c3f144e34aef62d35877bf2cc3425bcb5e4708
Submitter: Zuul
Branch: master

commit 15c3f144e34aef62d35877bf2cc3425bcb5e4708
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jun 14 11:22:14 2019 +0200

    Fix bagpipe driver to work with SQLAlchemy 1.3

    In SQLAlchemy 1.3 there was introduced change which caused failures of
    unit tests in networking-bgpvpn. See [1] for details.

    This patch fixes this by setting explicity columns on which join is done.

    [1] https://docs.sqlalchemy.org/en/13/changelog/migration_13.html#\
            query-join-handles-ambiguity-in-deciding-the-left-side-more-explicitly

    Change-Id: If1b3f69b91bc961693cc442986f9e8c725a4d3bd
    Closes-Bug: #1833051

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-bgpvpn 11.0.0.0b1 development milestone.