iscsi.service on host should be disabled to avoid iscsid is started at host when some stale shutdown happens

[Takashi Kajinami]

Since Queens, we run iscsid running inside container, and disable the one running on host.
However, when some stale shutdown happens, iscsi.service is started when booting that stale node,
and it launches iscsid.service on host.

This makes iscsid container stuck in "Restarting" with the following error.

~~~
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Validating config file
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Kolla config strategy set to: COPY_ALWAYS
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying service configuration files
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Deleting /etc/iscsi/iscsid.conf
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying /var/lib/kolla/config_files/src-iscsid/iscsid.conf to /etc/iscsi/iscsid.conf
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Deleting /etc/iscsi/initiatorname.iscsi
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Copying /var/lib/kolla/config_files/src-iscsid/initiatorname.iscsi to /etc/iscsi/initiatorname.iscsi
Jun 14 17:11:12 compute-1 journal: INFO:__main__:Writing out command to execute
Jun 14 17:11:12 compute-1 journal: ++ cat /run_command
Jun 14 17:11:12 compute-1 journal: Running command: '/usr/sbin/iscsid -f'
Jun 14 17:11:12 compute-1 journal: + CMD='/usr/sbin/iscsid -f'
Jun 14 17:11:12 compute-1 journal: + ARGS=
Jun 14 17:11:12 compute-1 journal: + [[ ! -n '' ]]
Jun 14 17:11:12 compute-1 journal: + . kolla_extend_start
Jun 14 17:11:12 compute-1 journal: ++ [[ ! -f /etc/iscsi/initiatorname.iscsi ]]
Jun 14 17:11:12 compute-1 journal: + echo 'Running command: '\''/usr/sbin/iscsid -f'\'''
Jun 14 17:11:12 compute-1 journal: + exec /usr/sbin/iscsid -f
Jun 14 17:11:12 compute-1 journal: iscsid: Can not bind IPC socket
~~~

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/665564

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665564
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0d67ecaf75d9375e2a88479514ce6cb7e910ec5e
Submitter: Zuul
Branch: master

commit 0d67ecaf75d9375e2a88479514ce6cb7e910ec5e
Author: Takashi Kajinami <email address hidden>
Date: Mon Jun 17 09:56:07 2019 +0900

    Disable iscsi.service to avoid iscsid on host from getting started

    When some stale shutdown happens on the node, iscsi.service detects
    remaining information about iscsi connection, and recovers connections
    based on the information, with starting iscsid service on host.
    This causes a collision between iscsid on host and iscsid in container,
    which makes iscsid container keep restarting.

    This patch makes sure that iscsi.service on host is disabled
    when we deploy iscsid container, to avoid iscsid on host is started
    unexpectedly.

    Change-Id: I6c36cd15edfa53c3c76be9095ff40cecf451490d
    Closes-Bug: #1833019

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/665821

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/665825

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/665829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665821
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5e70fa86918e7274e8ea02e79fa7a32e2ac22741
Submitter: Zuul
Branch: stable/stein

commit 5e70fa86918e7274e8ea02e79fa7a32e2ac22741
Author: Takashi Kajinami <email address hidden>
Date: Mon Jun 17 09:56:07 2019 +0900

    Disable iscsi.service to avoid iscsid on host from getting started

    When some stale shutdown happens on the node, iscsi.service detects
    remaining information about iscsi connection, and recovers connections
    based on the information, with starting iscsid service on host.
    This causes a collision between iscsid on host and iscsid in container,
    which makes iscsid container keep restarting.

    This patch makes sure that iscsi.service on host is disabled
    when we deploy iscsid container, to avoid iscsid on host is started
    unexpectedly.

    Change-Id: I6c36cd15edfa53c3c76be9095ff40cecf451490d
    Closes-Bug: #1833019
    (cherry picked from commit 0d67ecaf75d9375e2a88479514ce6cb7e910ec5e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665825
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0ff24b93973378605219650b255ba2fda4730fba
Submitter: Zuul
Branch: stable/rocky

commit 0ff24b93973378605219650b255ba2fda4730fba
Author: Takashi Kajinami <email address hidden>
Date: Mon Jun 17 09:56:07 2019 +0900

    Disable iscsi.service to avoid iscsid on host from getting started

    When some stale shutdown happens on the node, iscsi.service detects
    remaining information about iscsi connection, and recovers connections
    based on the information, with starting iscsid service on host.
    This causes a collision between iscsid on host and iscsid in container,
    which makes iscsid container keep restarting.

    This patch makes sure that iscsi.service on host is disabled
    when we deploy iscsid container, to avoid iscsid on host is started
    unexpectedly.

    Conflicts:
            docker/services/iscsid.yaml

    Change-Id: I6c36cd15edfa53c3c76be9095ff40cecf451490d
    Closes-Bug: #1833019
    (cherry picked from commit 0d67ecaf75d9375e2a88479514ce6cb7e910ec5e)
    (cherry picked from commit 5e70fa86918e7274e8ea02e79fa7a32e2ac22741)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665829
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a1fc0f6134bdd7611157b26ca0d02ac622993b4c
Submitter: Zuul
Branch: stable/queens

commit a1fc0f6134bdd7611157b26ca0d02ac622993b4c
Author: Takashi Kajinami <email address hidden>
Date: Mon Jun 17 09:56:07 2019 +0900

    Disable iscsi.service to avoid iscsid on host from getting started

    When some stale shutdown happens on the node, iscsi.service detects
    remaining information about iscsi connection, and recovers connections
    based on the information, with starting iscsid service on host.
    This causes a collision between iscsid on host and iscsid in container,
    which makes iscsid container keep restarting.

    This patch makes sure that iscsi.service on host is disabled
    when we deploy iscsid container, to avoid iscsid on host is started
    unexpectedly.

    Conflicts:
            docker/services/iscsid.yaml

    Change-Id: I6c36cd15edfa53c3c76be9095ff40cecf451490d
    Closes-Bug: #1833019
    (cherry picked from commit 0d67ecaf75d9375e2a88479514ce6cb7e910ec5e)
    (cherry picked from commit 5e70fa86918e7274e8ea02e79fa7a32e2ac22741)
    (cherry picked from commit 0ff24b93973378605219650b255ba2fda4730fba)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.1 release.