Rocky minor upgrade fails if undercloud images registry is used

[Anton Antonov]

Description:

  My Rocky RDO was deployed using the default docker images registry docker.io/tripleomaster. For a minor update I decided to use the undercloud registry instead because of the bug https://bugs.launchpad.net/tripleo/+bug/1832932
 The images were successfully pulled from the registry to Controller nodes and containers stared. But, "pcs status" reported that the containers started with 'unknown error' and Pacemaker resources were stopped.

Steps to reproduce:

1. Prepare images and overcloud update. The undercloud registry is used for docker images:

```
openstack tripleo container image prepare default \
  --local-push-destination \
  --output-env-file /home/stack/vxrdo/templates/containers-prepare-parameter.yaml

openstack overcloud update prepare ... \
  -e /home/stack/vxrdo/templates/containers-prepare-parameter.yaml

openstack overcloud external-update run --tags container_image_prepare

```

2. Update a Controller node
```
openstack overcloud update run --nodes ap13-ctrl2
```

  The update command finished successfully.
  Please find the whole output of the "overcloud update run" command attached to this bug

Expected result:

  The controller node is functional and Pacemaker resource are successfully started

Actual results:

   Pacemaker resources are stopped because of an error "failed to pull image docker.io/tripleorocky/..." although "10.35.5.1:8787/tripleorocky/" registry should be used instead.

```
[root@ap13-ctrl2 ~]# pcs status
Cluster name: tripleo_cluster
Stack: corosync
Current DC: ap12-ctrl3 (version 1.1.19-8.el7_6.4-c3c624ea3d) - partition with quorum
Last updated: Sat Jun 15 17:26:39 2019
Last change: Sat Jun 15 16:54:14 2019 by root via cibadmin on ap13-ctrl2

12 nodes configured
37 resources configured

Online: [ ap12-ctrl3 ap13-ctrl2 ap14-ctrl1 ]
GuestOnline: [ galera-bundle-0@ap12-ctrl3 rabbitmq-bundle-0@ap12-ctrl3 redis-bundle-0@ap12-ctrl3 ]

Full list of resources:

 Docker container set: rabbitmq-bundle [docker.io/tripleorocky/centos-binary-rabbitmq:pcmklatest]
   rabbitmq-bundle-0 (ocf::heartbeat:rabbitmq-cluster): Started ap12-ctrl3
   rabbitmq-bundle-1 (ocf::heartbeat:rabbitmq-cluster): Stopped
   rabbitmq-bundle-2 (ocf::heartbeat:rabbitmq-cluster): Stopped
 Docker container set: galera-bundle [docker.io/tripleorocky/centos-binary-mariadb:pcmklatest]
   galera-bundle-0 (ocf::heartbeat:galera): Master ap12-ctrl3
   galera-bundle-1 (ocf::heartbeat:galera): Stopped
   galera-bundle-2 (ocf::heartbeat:galera): Stopped
 Docker container set: redis-bundle [docker.io/tripleorocky/centos-binary-redis:pcmklatest]
   redis-bundle-0 (ocf::heartbeat:redis): Master ap12-ctrl3
   redis-bundle-1 (ocf::heartbeat:redis): Stopped
   redis-bundle-2 (ocf::heartbeat:redis): Stopped
 ip-10.35.5.9 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 ip-10.35.10.9 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 ip-10.35.6.8 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 ip-10.35.6.9 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 ip-10.35.8.9 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 ip-10.35.9.9 (ocf::heartbeat:IPaddr2): Started ap12-ctrl3
 Docker container set: haproxy-bundle [docker.io/tripleorocky/centos-binary-haproxy:pcmklatest]
   haproxy-bundle-docker-0 (ocf::heartbeat:docker): Started ap12-ctrl3
   haproxy-bundle-docker-1 (ocf::heartbeat:docker): Stopped
   haproxy-bundle-docker-2 (ocf::heartbeat:docker): Stopped
 Docker container: openstack-cinder-volume [docker.io/tripleorocky/centos-binary-cinder-volume:pcmklatest]
   openstack-cinder-volume-docker-0 (ocf::heartbeat:docker): Started ap12-ctrl3

Failed Actions:
* rabbitmq-bundle-docker-1_start_0 on ap13-ctrl2 'unknown error' (1): call=81, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-rabbitmq:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:45 2019', queued=0ms, exec=2248ms
* rabbitmq-bundle-docker-2_start_0 on ap13-ctrl2 'unknown error' (1): call=89, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-rabbitmq:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:48 2019', queued=0ms, exec=1301ms
* galera-bundle-docker-1_start_0 on ap13-ctrl2 'unknown error' (1): call=84, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-mariadb:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:45 2019', queued=0ms, exec=2055ms
* galera-bundle-docker-2_start_0 on ap13-ctrl2 'unknown error' (1): call=94, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-mariadb:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:48 2019', queued=0ms, exec=1138ms
* redis-bundle-docker-1_start_0 on ap13-ctrl2 'unknown error' (1): call=83, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-redis:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:45 2019', queued=0ms, exec=2222ms
* redis-bundle-docker-2_start_0 on ap13-ctrl2 'unknown error' (1): call=95, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-redis:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:48 2019', queued=0ms, exec=1713ms
* haproxy-bundle-docker-1_start_0 on ap13-ctrl2 'unknown error' (1): call=82, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-haproxy:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:45 2019', queued=0ms, exec=1384ms
* haproxy-bundle-docker-2_start_0 on ap13-ctrl2 'unknown error' (1): call=93, status=complete, exitreason='failed to pull image docker.io/tripleorocky/centos-binary-haproxy:pcmklatest',
    last-rc-change='Sat Jun 15 17:25:48 2019', queued=0ms, exec=1164ms

Daemon Status:
  corosync: active/enabled
  pacemaker: active/enabled
  pcsd: active/enabled
```

Environment:
```
(undercloud) [stack@undercloud ~]$ rpm -qa|grep tripleo
ansible-role-tripleo-modify-image-1.0.1-0.20190612031350.367f3e0.el7.noarch
puppet-tripleo-9.4.1-0.20190608052722.b56985d.el7.noarch
openstack-tripleo-validations-9.3.2-0.20190611232838.8a84c01.el7.noarch
openstack-tripleo-image-elements-9.1.1-0.20190604163040.a66a60d.el7.noarch
openstack-tripleo-heat-templates-9.3.1-0.20190613210447.11e842d.el7.noarch
python-tripleoclient-heat-installer-10.6.2-0.20190607003405.8d9fa8a.el7.noarch
ansible-tripleo-ipsec-9.1.1-0.20190513182453.ffe104c.el7.noarch
python2-tripleo-common-9.5.1-0.20190611182931.83db258.el7.noarch
openstack-tripleo-puppet-elements-9.0.2-0.20190605172111.81729a1.el7.noarch
python2-tripleo-repos-0.0.1-0.20190612102607.9b3187e.el7.noarch
openstack-tripleo-common-containers-9.5.1-0.20190611182931.83db258.el7.noarch
openstack-tripleo-common-9.5.1-0.20190611182931.83db258.el7.noarch
python-tripleoclient-10.6.2-0.20190607003405.8d9fa8a.el7.noarch
```